Commons:Bots/Requests/Deletion Notification Bot
Operator: Eatcha (talk · contributions · Statistics · Recent activity · block log · User rights log · uploads · Global account information)
Bot's tasks for which permission is being sought:
- Notify users if their files are marked for deletion (nominator didn't notified). All types of deletion request will be supported.
- If a file is deleted and no DR notice on Talk-Page.
, and the User is not an admin.
Automatic or manually assisted: Automatic
Edit type (e.g. Continuous, daily, one time run): 24*7
Maximum edit rate (e.g. edits per minute):10 (± 5) per minutes
Bot flag requested: (Y/N): Y
Programming language(s): Python
Source code: GitHub
Eatcha (talk) 18:04, 24 March 2020 (UTC)
Discussion
- Original proposed at Commons:Bots/Work_requests/Archive_15#Notification_of_deletion_tags_for_the_uploader_when_the_tagger_didn't_notify // Eatcha (talk) 18:11, 24 March 2020 (UTC)
- Ping users,User:Alexis JazzUser:Masumrezarock100User:MajoraUser:~riley , am I supposed to use traditional red templates or custom text ? // Eatcha (talk) 18:21, 24 March 2020 (UTC)
- Traditional templates preferred in my opinion. ~riley (talk) 03:12, 25 March 2020 (UTC)
- What do you mean by "Can't tell" for maximum edit rate? ~riley (talk) 03:12, 25 March 2020 (UTC)
- ~riley I don't have any data to guess the rate, "can't tell" will be replaced by some integer before this request gets accepted. Eatcha (talk) 14:46, 25 March 2020 (UTC)
- The general expectation is that you list the throttle you have put in place to ensure maxlag or a reasonable rate is not exceeded - you don't have to wait for it to edit to guess or average the rate. ~riley (talk) 16:43, 25 March 2020 (UTC)
- Done -- Eatcha (talk) 02:33, 26 March 2020 (UTC)
- The general expectation is that you list the throttle you have put in place to ensure maxlag or a reasonable rate is not exceeded - you don't have to wait for it to edit to guess or average the rate. ~riley (talk) 16:43, 25 March 2020 (UTC)
- This has been one of top
105 on my wishlist for some time now, thanks. Can the bot also notify users of deletion, if they haven't been notified? Ahmadtalk 00:06, 26 March 2020 (UTC)- Ahmad Can you please clarify "Can the bot also notify users of deletion, if they haven't been notified?" ? Notify after the file has been hidden for non-admin/OS users? This will require admin rights or creation of a database for all files in deletion requests, with Uploader username this won't work if an admin deletes any files themselves without a DR/SD template. -- Eatcha (talk) 02:33, 26 March 2020 (UTC)
- Yes, like when an administrator deletes a file that hasn't been tagged, but doesn't notify the uploader of deletion. Isn't it possible to get the uploader's username from the upload log? Ahmadtalk 12:55, 26 March 2020 (UTC)
- Ahmad I uploaded a test file File:List of names in a spreadsheet.jpg, can you show me where is the upload log? I don't know if there's a thing called upload log, I am new to MediaWiki. I googled "upload log MediaWiki api" but found nothing relevant. Pywikibot docs returned nothing for upload log. Afaik there's a mediwiki api to get version history of a page, the oldest editor is the uploader. // Eatcha (talk) 13:24, 26 March 2020 (UTC)
- Sure. It's here. I'm not sure, but you may find mw:API:Logevents useful. Ahmadtalk 22:24, 26 March 2020 (UTC)
- Ahmad Thanks, it's very useful. -- Eatcha (talk) 08:21, 27 March 2020 (UTC)
- Ahmad I uploaded a test file File:List of names in a spreadsheet.jpg, can you show me where is the upload log? I don't know if there's a thing called upload log, I am new to MediaWiki. I googled "upload log MediaWiki api" but found nothing relevant. Pywikibot docs returned nothing for upload log. Afaik there's a mediwiki api to get version history of a page, the oldest editor is the uploader. // Eatcha (talk) 13:24, 26 March 2020 (UTC)
- Yes, like when an administrator deletes a file that hasn't been tagged, but doesn't notify the uploader of deletion. Isn't it possible to get the uploader's username from the upload log? Ahmadtalk 12:55, 26 March 2020 (UTC)
- Ahmad Can you please clarify "Can the bot also notify users of deletion, if they haven't been notified?" ? Notify after the file has been hidden for non-admin/OS users? This will require admin rights or creation of a database for all files in deletion requests, with Uploader username this won't work if an admin deletes any files themselves without a DR/SD template. -- Eatcha (talk) 02:33, 26 March 2020 (UTC)
- I couldn't complete the following dictionary, does anyone have any Idea if there's any default template for
Advertisements for speedy deletion, Other speedy deletions and Personal files for speedy deletion
dict = {
"Advertisements for speedy deletion": "{{subst:User:Deletion Notification Bot/NOADS|1=%s}}" % file_name,
"Copyright violations": "{{subst:User:Deletion Notification Bot/COPYVIO|1=%s}}" % file_name,
"Other speedy deletions": "{{subst:User:Deletion Notification Bot/SDEL|1=%s}}" % file_name,
"Personal files for speedy deletion": "{{subst:User:Deletion Notification Bot/personalNO|1=%s}}" % file_name,
"Deletion requests %s" % today.strftime("%B %Y") : "{{subst:idw|1=%s}}" % file_name,
"Media without a license as of %s" % today.strftime("%-d %B %Y") : "{{subst:image license|1=%s}}" % file_name,
"Media missing permission as of %s" % today.strftime("%-d %B %Y") : "{{subst:image permission|1=%s}}" % file_name,
"Media without a source as of %s" % today.strftime("%-d %B %Y") : "{{subst:Image source |1=%s}}" % file_name,
}
Eatcha (talk) 15:02, 26 March 2020 (UTC)
- Is there any problem if I make 30 test edits(15 deleted notification and 15 DR/SD notifications) ? This involves notifying users , I do not want to repeat my mistakes at the other BRFA over here and get this bot blocked, but a test is required IMO. // Eatcha (talk) 08:28, 27 March 2020 (UTC)
- Example notification : here. The bot will check if a DR notice is available on the page, if DR notice is available will not add deleted notice. -- Eatcha (talk) 10:40, 27 March 2020 (UTC)
- I'd strongly suggest to start this slowly over a long period, in order not to flood undel requests with nonsense objections and tune the notification text based on the appearing results. --Krd 17:48, 3 April 2020 (UTC)
- Made 15 edits (post deletion), are there any suggestions ? I didn't found any template for Advertisements for speedy deletion, Other speedy deletions and Personal files for speedy deletion, will notify (pre deletion) in English for these 3 cases. -- Eatcha (talk) 10:31, 4 April 2020 (UTC)
- Krd Test run complete, I can make the bot not add the link to Commons:Undeletion requests/Current requests if user has more than x templates or if he/she/they has edited Commons:Undeletion requests/Current requests recently. Add a small text " making too many non sense deletion requests can lead to you getting blocked from editing commons. " //Eatcha (talk) 09:28, 5 April 2020 (UTC)
- Add what where? We should not accuse or block threat any user by a bot message please! --Krd 10:16, 5 April 2020 (UTC)
- Add "Please do not make too many problematic un-deletion requests as this can lead to administrative actions. " at the end of these post deletion message. example edit
- Update:
- Custom templates no longer use the word "block". User:Deletion Notification Bot/NOADS, User:Deletion Notification Bot/SDEL, User:Deletion Notification Bot/NOADS and User:Deletion Notification Bot/COPYVIO.
- Eatcha (talk) 10:51, 5 April 2020 (UTC)
- I suggest to remove the "PS:" from the notification. It is bad style as it actually isn't "post scriptum". Please make a few more test edits. --Krd 07:59, 10 April 2020 (UTC)
- Done 26 edits made (pre+post deletion notification included). Removed "PS:" from pre deletion message. -- Eatcha (talk) 10:15, 10 April 2020 (UTC)
- Please check the message formatting. E.g. in Special:Diff/410261767 there is too much vertical whitespace but missing space between colon and deletion reason.
- I also suggest to put a warning on the bot's talk page that questions regarding deletions will not be answered there (unless anybody does watch the page). --Krd 11:03, 10 April 2020 (UTC)
- Done Made 3 edits (1, 2 and 3). Updated talk page User talk:Deletion Notification Bot // Eatcha (talk) 14:34, 11 April 2020 (UTC)
- Per no. two out of these three, can you please disable notifications if the uploader was a bot? --Krd 09:35, 18 April 2020 (UTC)
- Okay, will not add template if user has 'bot' flag or username ends with '[Bb]ot' // Eatcha (talk) 15:39, 18 April 2020 (UTC)
- Please make a bigger test run, perhaps around 50 edits of different kinds. Thank you. --Krd 04:41, 22 April 2020 (UTC)
- Done 56 edits. //Eatcha (talk) 05:15, 23 April 2020 (UTC)
- Please make a bigger test run, perhaps around 50 edits of different kinds. Thank you. --Krd 04:41, 22 April 2020 (UTC)
- Okay, will not add template if user has 'bot' flag or username ends with '[Bb]ot' // Eatcha (talk) 15:39, 18 April 2020 (UTC)
- Per no. two out of these three, can you please disable notifications if the uploader was a bot? --Krd 09:35, 18 April 2020 (UTC)
- Done Made 3 edits (1, 2 and 3). Updated talk page User talk:Deletion Notification Bot // Eatcha (talk) 14:34, 11 April 2020 (UTC)
Possible problem with the bot?
Hello! Hope you are well. I stop by here for a particular issue about your bot Deletion Notification Bot. After reviewing his contributions, I see that he sends messages that "were not delivered" to other users (Notices from: DW, SD, Not licensing, among others). However, I comment on this inconvenience Special:Diff/414178510 and Special:Diff/414178540 both pages that the bot has notified me, is the effect of an image transfer, therefore since redirection is unnecessary, I have marked it for Speedy delete. That particular action may erroneously notify a user (Filemover or another user who has marked the deletion) which mark as SD to unnecessary redirect pages. Do you think you can avoid these kinds of problems?. Regarding the notice that is on my talk page, you can undo or hide it please. Kind regards Mazbel – 08:28, 23 April 2020 (UTC)
- Mazbel I can iterate over all the edit objects to check if the uploader is the sole contributor of a particular page, if condition is True then will not notify the uploader. And please use this page for disccusion about this bot, currently in trial phase, best if all issues are discussed here. What's your opinion @ Krd ? //Eatcha (talk) 08:41, 23 April 2020 (UTC)
- Myabe just check the extreme contributors if same then will not notify, it's more scalable than iteration over all edits. -- Eatcha (talk) 08:47, 23 April 2020 (UTC)
- I don't understand the last statement, please say again. --Krd 07:21, 26 April 2020 (UTC)
- Checking all edits searching for who added the deletion template should have a limit, let say lastest 5 edits. If I try to check all edits and compare the editor with the uploader this would take too long to complete checking a single file. I should also check editors for Commons:Deletion requests/File:Filename.extension for a given file, but with a restriction. The nominator and last 3 editors. If any of them is uploader, will not notify. Similar for deletion, if the admin who deleted a file was the uploader. // Eatcha (talk) 06:09, 27 April 2020 (UTC)
- You can stop as soon as you have found the right versions, starting from the most recent one. This will match at the first try, i.e. the most recent edit, in 98% of all cases. For the rest I think it's worth to spend the additional queries and computing time, as the job doesn't have to be strictly realtime anyway. --Krd 05:54, 5 May 2020 (UTC)
- I'll accomplish that. // Eatcha (talk) 17:06, 5 May 2020 (UTC)
- You can stop as soon as you have found the right versions, starting from the most recent one. This will match at the first try, i.e. the most recent edit, in 98% of all cases. For the rest I think it's worth to spend the additional queries and computing time, as the job doesn't have to be strictly realtime anyway. --Krd 05:54, 5 May 2020 (UTC)
- Checking all edits searching for who added the deletion template should have a limit, let say lastest 5 edits. If I try to check all edits and compare the editor with the uploader this would take too long to complete checking a single file. I should also check editors for Commons:Deletion requests/File:Filename.extension for a given file, but with a restriction. The nominator and last 3 editors. If any of them is uploader, will not notify. Similar for deletion, if the admin who deleted a file was the uploader. // Eatcha (talk) 06:09, 27 April 2020 (UTC)
- I don't understand the last statement, please say again. --Krd 07:21, 26 April 2020 (UTC)
- Myabe just check the extreme contributors if same then will not notify, it's more scalable than iteration over all edits. -- Eatcha (talk) 08:47, 23 April 2020 (UTC)
@Eatcha: Please advise how we proceed with this. Are all issues resolved, can the request be approved? --Krd 03:53, 10 May 2020 (UTC)
- Krd
- Are all issues resolved : Yes. But I can't predict what issues will arise during the full scale run.
- How we proceed with this : I will monitor this task (full scale) for a week and stop the bot whenever any user complains. And address the issues. And restart the bot.
- Can the request be approved : Yes, but this task may have issues when running on full scale. I don't have enough idea about deletions.
- \\Eatcha (talk) 04:16, 10 May 2020 (UTC)
- Sounds good, bot flag set for continuous trial. --Krd 14:08, 12 May 2020 (UTC)
In case of mass deletion requests, this bot creates a flood of individual messages, all broken like this one which do not link correctly to the DR. --AFBorchert (talk) 08:25, 13 May 2020 (UTC)
Fixed And rate limited to max 3 notifications. example edit // Eatcha (talk) 10:14, 13 May 2020 (UTC)- Thank you for this and, of course, thank you also for developing this bot. I find it very valuable to have a bot that makes sure that notifications will be delivered even if they were accidently not posted. But allow me to return to this point: How hard is it to generate just one post for one DR? --AFBorchert (talk) 11:05, 13 May 2020 (UTC)
- Onwards one dr page will result in one notification ONLY. And rate limit increased to 7 per hour per user // Eatcha (talk) 14:56, 13 May 2020 (UTC)
- Thank you for this and, of course, thank you also for developing this bot. I find it very valuable to have a bot that makes sure that notifications will be delivered even if they were accidently not posted. But allow me to return to this point: How hard is it to generate just one post for one DR? --AFBorchert (talk) 11:05, 13 May 2020 (UTC)
I have requested the bot be forcably shut off at [1]. There is no good reason to generically point users to the help desk rather than stating who is the DR nominator. Avoiding this just confuses users and fails to make the bureaucracy accountable. --Fæ (talk) 10:12, 13 May 2020 (UTC)
- Add who is the DR nominator : Doing… Will add the name of nominator but will still point them to help desk. I don't see any problem in pointing users to the help desk. // Eatcha (talk) 10:21, 13 May 2020 (UTC)
- The harm is wasting everyone's time on the help desk. The nominator is the one who should be leaving uploader notifications and in the first instance, uploaders should be able to ask questions about the nominations of the nominator on the uploader's own talk page where the notice is. This avoids misunderstandings and may help accidental nominations being found early. --Fæ (talk) 10:30, 13 May 2020 (UTC)
- 1) The nominator is the one who should be leaving uploader notifications and in the first instance : Many nominators don't notify. Primary reason for operating this bot. Read Commons:Bots/Work_requests/Archive_15#Notification_of_deletion_tags_for_the_uploader_when_the_tagger_didn't_notify
- 2) uploaders should be able to ask questions about the nominations of the nominator on the uploader's own talk page where the notice is : If there's no notification on the talk page, how will the uploader know about the deletion ? The speedy deletions can take less than an hour.
- Eatcha (talk) 10:42, 13 May 2020 (UTC)
- This is poor framing. If the intention of the bot is to 'repair' missing notifications, the bot is acting on behalf of the DR nominator, not the help desk, nor the bot operator. --Fæ (talk) 11:32, 13 May 2020 (UTC)
- The harm is wasting everyone's time on the help desk. The nominator is the one who should be leaving uploader notifications and in the first instance, uploaders should be able to ask questions about the nominations of the nominator on the uploader's own talk page where the notice is. This avoids misunderstandings and may help accidental nominations being found early. --Fæ (talk) 10:30, 13 May 2020 (UTC)
- Q to Fæ : You said "it is relatively trivial for an automated process to work out who raised the deletion request" ? How would you detect who nominated a file for deletion ? Iterate over recent x edits ? Or something else. BTW: It's should be less expensive/easy for regular DRs. // Eatcha (talk) 10:56, 13 May 2020 (UTC)
- Hm... isn't it possible to see who created the DR? --AFBorchert (talk) 11:05, 13 May 2020 (UTC)
- There are no DR page for any deletion nomination other that Standard DRs. Speedy deletion, Media without a license and Media missing permission etc. don't involves creation of a discussion page. No new pages = need to iterate over older edits to find the nominator, in the worst case you spend time directly proportional to the number of edits and find nothing. // Eatcha (talk) 14:39, 13 May 2020 (UTC)
- I'm not going to review your code for you, but recent image page version history however you call it up it, should be short and efficiently easy to filter based on edit comment or content. --Fæ (talk) 11:30, 13 May 2020 (UTC)
- Okay, will do this. But will only check the recent 5 edits and if nominator not found will not specify the nominators name. This should be fine (at least, IMO) for most of the cases, and will prevent any expensive iteration. // Eatcha (talk) 14:39, 13 May 2020 (UTC)
- Done // Eatcha (talk) 05:24, 14 May 2020 (UTC)
- I'm iterating over all edits (reverse order) and checking who added the template. // Eatcha (talk) 06:10, 15 May 2020 (UTC)
- Done // Eatcha (talk) 05:24, 14 May 2020 (UTC)
- Okay, will do this. But will only check the recent 5 edits and if nominator not found will not specify the nominators name. This should be fine (at least, IMO) for most of the cases, and will prevent any expensive iteration. // Eatcha (talk) 14:39, 13 May 2020 (UTC)
- Hm... isn't it possible to see who created the DR? --AFBorchert (talk) 11:05, 13 May 2020 (UTC)
I was notified about this file I didn't upload but I moved it last year and it turned to a redirect. It was tagged by the uploader. Any chance that doesn't happen again? Thanks. 1989 (talk) 04:28, 15 May 2020 (UTC)
- I don't have the rights to check that file, but my guess is the first edit summary will always contain the sub-string "moved page" in it's edit summary/comment. Done If I am correct. // Eatcha (talk) 05:55, 15 May 2020 (UTC)
- User talk:Monicasanchezgonzalez
You are operator of Deletion operator bot. Please look the user talkpage. The user got multiple notices, that her files got deleted due to their own request. In my opinion this makes no sense. I understand, that it's difficult to sort out files deleted due to uploader's request, but anyway, it makes no sense. In addition, I got some twenty notices, that I deleted some files speedily. Do you think about administrators? It's really annoying to get hundred such notices each day. Maybe {{Noping}} is worth trying. And if multiple files of same uploader are nominated for deletion, then only one template is written on the user talkpage and below is list of affected files. Would be better, when Monica got only one message with list of affected files. Taivo (talk) 15:35, 18 May 2020 (UTC)
- I stopped the post deletion notice part of the bot. I was not aware that a bot can ping an user ( includes admins ). I will fix this issue in the next run. These are not pre/normal deletion request notices but post deletion notice to detect deletions when the uploader was never notified. These post dr notices are kinda hard to handle because the files are hidden from non admin users, only clue is the dr reason mentioned by the admins which are inconsistent(not machine readable). // Eatcha (talk) 16:54, 18 May 2020 (UTC)
- Done, nominators and admins will not get unwanted pings anymore. And the issue with self requested deletions can be avoid by checking for multiple keywords in the deletion reason, post deletion notification will remain disabled until I solve the issue. // Eatcha (talk) 05:04, 19 May 2020 (UTC)
- From bot's talk page
For the first time ever, I just received four notifications from this bot for files that I had correctly deleted on sight. If Admins get notifications for every {{Speedy}} they make they may as well stop making them. . Jim . . . (Jameslwoodward) (talk to me) 16:57, 18 May 2020 (UTC)
- Jameslwoodward Oops, I wasn't aware of the pings. I was informed by User:Taivo here. The issue is now fixed (commits : 1 and 2). If there is no problem, you should unblock the bot. It's under one week flagged trial period and these issues were not identified in the small test runs.
- And I will need to move your message on this page to Commons:Bots/Requests/Deletion Notification Bot, this should ensure that all issues are kept in one centralized discussion page. -- Eatcha (talk) 04:57, 19 May 2020 (UTC)
Unblock Done by 1989. Thanks, . Jim . . . (Jameslwoodward) (talk to me) 10:45, 19 May 2020 (UTC)
- Please do to inform users the are indefinitely blocked or globally locked. We don't feed abusers. --Krd 06:22, 20 May 2020 (UTC)
- I assume it's a typo and you meant "don't inform users who are indefinitely blocked or globally locked" Done -- Eatcha (talk) 14:49, 20 May 2020 (UTC)
- Please test slower or use dry runs. It seems there appear issues with every recent test, so this bot causes disruption currently. --Krd 06:22, 20 May 2020 (UTC)
- Done Will run the bot when I'm actively monitoring for issues. // Eatcha (talk) 14:49, 20 May 2020 (UTC)
- No more bugs found, should be approved IMO. // Eatcha (talk) 15:03, 26 May 2020 (UTC)
- And now running without supervision. Of course throttled to minimise damage if any at all. // Eatcha (talk) 18:49, 26 May 2020 (UTC)
- No more bugs found, should be approved IMO. // Eatcha (talk) 15:03, 26 May 2020 (UTC)
- Done Will run the bot when I'm actively monitoring for issues. // Eatcha (talk) 14:49, 20 May 2020 (UTC)
- This line from the source code:
new_text = ( old_text + "\n{{subst:User:Deletion Notification Bot/deleted notice|1=%s}}Deleted by [https://commons.wikimedia.org/wiki/User:%s User:%s]. Reason for deletion : %s . \n~~~~" % (self.file_name, admin.replace(" ", "_"), admin, reason))
- Consider moving the "Deleted by ..." text to the User:Deletion Notification Bot/deleted notice template. That way, it can more easily be translated. The owner of the talk page does not necessarily speak English.
[https://commons.wikimedia.org/wiki/User:%s User:%s]
is bad syntax. The user might be using commons.m.wikimedia.org instead of commons.wikimedia.org. Consider using{{noping|%s}}
instead.- Let's say that I tag a file with {{subst:nsd}} after 23:50:00 but no later than 23:59:59 and don't notify the uploader. Will the bot notify the uploader? --Stefan2 (talk) 00:59, 2 June 2020 (UTC)
- Stefan2
- Will get back to this later, stopped the bot until then. Thanks // Eatcha (talk) 04:08, 2 June 2020 (UTC)
- Done commits 1 and 2 // Eatcha (talk) 05:22, 2 June 2020 (UTC)
- QLet's say that I tag a file with {{subst:nsd}} after 23:50:00 but no later than 23:59:59 and don't notify the uploader. Will the bot notify the uploader?
- A Yes, there's now way you create a DR and the file gets deleted without notifying the uploader. There are 2 different scripts that run independently but use the data by other script to check if the uploader was notified or not. If you tag a file at 23:59:59 this would likely be not handled by the pre deletion script but the post deletion scripts will take care of that. SIDENOTE: The bot will not notify for more than 7 DRs and 3 post deleted files per run to prevent spamming the talk-pages in case a vandal nominates all files by uploader for deletion. // Eatcha (talk) 05:35, 2 June 2020 (UTC)
- New edits 1 and 2. // Eatcha (talk) 05:36, 2 June 2020 (UTC)
- Done commits 1 and 2 // Eatcha (talk) 05:22, 2 June 2020 (UTC)
- Will get back to this later, stopped the bot until then. Thanks // Eatcha (talk) 04:08, 2 June 2020 (UTC)
- Comment and Question I think it is a nice feature that the bot informs users if one of their files are nominated for deletion and they are not already informed.
- If I moved a file from xx.wiki to Commons and it is nominated for deletion I think that the original uploader should be informed. Is that possible?
- If I upload a file and then add a speedy and ask for the file to be deleted will I get a notice?
- I think the latest edits look good. Can the bot be approved for a new trail? --MGA73 (talk) 18:45, 12 June 2020 (UTC)
- The original uploaders on xx.wiki are receiving the notification on their commons talk page if not blocked on commons nor globally locked/banned. {{Nobots}} is respected, inbuilt feature of the pywikibot.
- If you upload a file and tag the file for deletion with the same account (same unique username) you will not receive notification because you're already aware that you want the file deleted and notifying would be classified as spamming.
// Eatcha (talk) 17:11, 13 June 2020 (UTC)
- Sounds great! I think it should go online so we can see how it works! --MGA73 (talk) 20:24, 13 June 2020 (UTC)
- Do I understand correctly that another test run will be required? If yes, please continue accordingly, otherwise please summarize what will be the next step. --Krd 10:25, 14 June 2020 (UTC)
- It's working as expected and is ready to be approved. Thanks // Eatcha (talk) 10:35, 14 June 2020 (UTC)
- Do I understand correctly that another test run will be required? If yes, please continue accordingly, otherwise please summarize what will be the next step. --Krd 10:25, 14 June 2020 (UTC)
- Sounds great! I think it should go online so we can see how it works! --MGA73 (talk) 20:24, 13 June 2020 (UTC)
For the record: Commons:Administrators' noticeboard/User problems#Notification by bot problems --Krd 16:17, 15 June 2020 (UTC)
- I made this recommendation at ANUP as well, but I'll make it here too. I'd suggest that the bot attempt to delay notifications by about 30 minutes to prevent cases like User_talk:Iñaki_LL#Copyright_status:_File:Ataungo_ikuspegiak_1.jpg. AntiCompositeBot, as part of its approved bot task, may delay notifications by up to 10 minutes (in the current configuration). This introduces a race condition with this bot, where both bots will notify the same user for the same edit. In the case of User talk:Fæ, an edit conflict from Deletion Notification Bot caused AntiCompositeBot to fail to leave it's own notification. I've improved the edit conflict handling for ACB, but I would suggest that Deletion Notification Bot delay notification for at least 30 minutes to give bots and human editors a chance to notify other editors properly. While manual DR nominations are uncommon on Commons, I have personally seen human editors take more than 5 minutes to finish nominating a page for deletion and notify the page creator. --AntiCompositeNumber (talk) 16:55, 15 June 2020 (UTC)
- I think that a delay is the best solution. Consider a similar situation where a normal user manually creates a deletion request. You'd create the deletion discussion subpage, tag all files with {{Delete}} and notify the uploaders. If there are lots of files and lots of uploaders, the notifications might be posted several minutes after {{Delete}} was added. It's silly if the bot notifies the uploader about the deletion request if the nominator is going to notify the uploader one minute later. --Stefan2 (talk) 17:14, 15 June 2020 (UTC)
- The bot doesn't anymore notifies for any kind of DR created by ACBot, I'm not sure if 30 minutes is a good Idea there are copyright violations and speedy deletions processes where files are often deleted under 30 minutes. How about 15 minutes? And don't notify for DRs(any type) created by bots. // Eatcha (talk) 18:58, 15 June 2020 (UTC)
- @Eatcha: I think 15 minutes are fine. But why exclude all bots? Do we have any other bots nominating files for deletion? If a bot nominate a file for deletion I doubt there will be many cases where it takes more than 15 minutes to notify uploader. If it has not notified uploader after 15 minutes I'm sure it will never do that. Should it happen just ping me and I will be happy to clean up the users talk page and write a personal I'm-sorry letter :-) --MGA73 (talk) 20:46, 20 June 2020 (UTC)
- I didn't excluded all bots. There is atleast one bot that nominates file for deletion other than AntiCompsiteNumberBot. I will probably list those here after looking for them in the logs. // Eatcha (talk) 06:56, 22 June 2020 (UTC)
- @Eatcha: I think 15 minutes are fine. But why exclude all bots? Do we have any other bots nominating files for deletion? If a bot nominate a file for deletion I doubt there will be many cases where it takes more than 15 minutes to notify uploader. If it has not notified uploader after 15 minutes I'm sure it will never do that. Should it happen just ping me and I will be happy to clean up the users talk page and write a personal I'm-sorry letter :-) --MGA73 (talk) 20:46, 20 June 2020 (UTC)
- The bot doesn't anymore notifies for any kind of DR created by ACBot, I'm not sure if 30 minutes is a good Idea there are copyright violations and speedy deletions processes where files are often deleted under 30 minutes. How about 15 minutes? And don't notify for DRs(any type) created by bots. // Eatcha (talk) 18:58, 15 June 2020 (UTC)
The bot added a duplicate notification at User talk:GeethaGovind. Also, its explanation is not grammatically correct; it should start something like "I am a piece of software; please do not ask me questions but ask the user who nominated your file for deletion ..." Maybe "computer program" would be better than "piece of software". Graham87 (talk) 03:53, 22 June 2020 (UTC)
- Reason for dupe , case sensitive issue with the "File:" namespace. The bot now does not looks for file name with the the namespace. And fixed the incorrect explanation. // Eatcha (talk) 07:00, 22 June 2020 (UTC)
- Another issue reported here, fixed. // Eatcha (talk) 04:42, 25 June 2020 (UTC)
Again
The bot made the same four notifications three times on my discussion. Thank ou, but I noticed it the first time and reacted on them. I do need further notifications for the same files. [2] --JPF (talk) 17:55, 25 June 2020 (UTC)
- J Patrick Fischer Sorry, the bot uses database that's stored on wmf servers to prevent duplicate messages. It's possible that I was checking something locally on my computer and I don't have the older data on my machine. And when the database is not available it just checks the live wiki pages for detecting past messages. I cheked the program logs on server and test the program for your files on server and it appears fine to me. My apologies for the inconvenience. // Eatcha (talk) 04:29, 26 June 2020 (UTC)
tools.eatchabot at tools-sgebastion-07 in ~/Deletion-Notification-Bot on master [?]
$ grep -n "Liga Futebol Amadora" dump.txt
363: File:Liga Futebol Amadora.jpg , Uploaded by User:J. Patrick Fischer and nominated by User:Glorious 93
364:File:Liga Futebol Amadora.jpg was processed once. ***
tools.eatchabot at tools-sgebastion-07 in ~/Deletion-Notification-Bot on master [?]
$ grep -n "Kablaki FC" dump.txt
359: File:Kablaki FC.jpg , Uploaded by User:J. Patrick Fischer and nominated by User:Glorious 93
360:File:Kablaki FC.jpg was processed once. ***
tools.eatchabot at tools-sgebastion-07 in ~/Deletion-Notification-Bot on master [?]
If you don't mind can I move this section to Commons:Bots/Requests/Deletion Notification Bot. // Eatcha (talk) 04:29, 26 June 2020 (UTC)
- Of course. Thank you! --JPF (talk) 04:32, 26 June 2020 (UTC)
- Help:VisualFileChange.js is able to bundle multiple notifications to the same uploader. Can't the bot do this? The user who complained above was notified about four different files in four separate sections. --Stefan2 (talk) 10:38, 27 June 2020 (UTC)
- THese are copyright violations not standard DRs, can you show me an example where copyvio templates were bundled by Help:VisualFileChange.js. If there's a template already being used I have no problem in implmenting bundled copyright violation notices. // Eatcha (talk) 15:16, 28 June 2020 (UTC)
- See Special:Diff/429520052. I wasn't sure where to look, so I started searching for copyvios until I found a user who had multiple copyvios. --Stefan2 (talk) 19:41, 28 June 2020 (UTC)
- Stefan, how should the bot handle if files have different reason for deletion? The files nominated manually can have different reasons for deletion. Maybe reason for each file next to it in the list? // Eatcha (talk) 14:33, 29 June 2020 (UTC)
- If the file has been nominated for deletion, you're not quoting the deletion rationale or specifying who the nominator is, right? If there are two {{Copyvio}} and three {{Delete}}, you could bundle the copyvios under one single {{subst:copyvionote}} and the deletion requests under one single {{subst:idw}}, reducing the number of talk page sections from five to two. --Stefan2 (talk) 17:55, 30 June 2020 (UTC)
If the file has been nominated for deletion, you're not quoting the deletion rationale or specifying who the nominator is, right?
No, I'm scraping the rationale and trying to specify who nomiated the file for deletion. It's not possible in every case to identify the nomaintor beacuse we have way too many templates that can be used to nominte a file for deletion, but accounding to logs more than more than 95 % files' nominator was succefully idnetified. // Eatcha (talk) 10:51, 1 July 2020 (UTC)- @Stefan2: If files should be bundled is it a good idea to bundle different types? If a user upload 1 copyvio and 50 files with no license and the bot bundle 51 files under "copyvio" then the next admin will think "Wow! Lets us block that user!". Anyway I think it is a good idea with this bot and think it should be approved. As with everything else it can be improved along the way :-) So I will just make my Support and not make any further comments. Good work @Eatcha: and thank you for making the request. --MGA73 (talk) 18:47, 30 June 2020 (UTC)
- If files should be bundled is it a good idea to bundle different types? No. That's why I proposed bundling only if the notification template is the same for both of them. --Stefan2 (talk) 22:09, 30 June 2020 (UTC)
- Just to make it clear, I'll bundle if the notification template is the same for both of them as per todays design of the bot(e.g. all copyvio in one sextion, all person photos in another and so on.). And add the nominator along with the reson if identified and scraped. This should require some serious re-designing and re-factoring, will try to ship by tomorrow night. // Eatcha (talk) 11:00, 1 July 2020 (UTC)
- Done Now bundling files. // Eatcha (talk) 05:16, 2 July 2020 (UTC)
- Just to make it clear, I'll bundle if the notification template is the same for both of them as per todays design of the bot(e.g. all copyvio in one sextion, all person photos in another and so on.). And add the nominator along with the reson if identified and scraped. This should require some serious re-designing and re-factoring, will try to ship by tomorrow night. // Eatcha (talk) 11:00, 1 July 2020 (UTC)
- If files should be bundled is it a good idea to bundle different types? No. That's why I proposed bundling only if the notification template is the same for both of them. --Stefan2 (talk) 22:09, 30 June 2020 (UTC)
- If the file has been nominated for deletion, you're not quoting the deletion rationale or specifying who the nominator is, right? If there are two {{Copyvio}} and three {{Delete}}, you could bundle the copyvios under one single {{subst:copyvionote}} and the deletion requests under one single {{subst:idw}}, reducing the number of talk page sections from five to two. --Stefan2 (talk) 17:55, 30 June 2020 (UTC)
- Stefan, how should the bot handle if files have different reason for deletion? The files nominated manually can have different reasons for deletion. Maybe reason for each file next to it in the list? // Eatcha (talk) 14:33, 29 June 2020 (UTC)
- See Special:Diff/429520052. I wasn't sure where to look, so I started searching for copyvios until I found a user who had multiple copyvios. --Stefan2 (talk) 19:41, 28 June 2020 (UTC)
- THese are copyright violations not standard DRs, can you show me an example where copyvio templates were bundled by Help:VisualFileChange.js. If there's a template already being used I have no problem in implmenting bundled copyright violation notices. // Eatcha (talk) 15:16, 28 June 2020 (UTC)
- Please summarise which issues are now still unresolved. --Krd 17:43, 11 July 2020 (UTC)
- All issues resolved. // Eatcha (talk) 14:45, 12 July 2020 (UTC)
- If the deletion rationale includes a link to the category namespace, ensure that you escape the page title with a colon so that user talk pages aren't categorised. See Special:Diff/432720140. --Stefan2 (talk) 23:53, 12 July 2020 (UTC)
- fixed Thanks for notifying. // Eatcha (talk) 02:12, 13 July 2020 (UTC)
Section break
@Eatcha: I noticed this User_talk:そらみみ#Copyright_status:_File:Inari-jinja_in_Oiwa-jinja_(Hitachi).jpg.
- User:Taisuke.Kasuya upload the file at 14:23 on December 30 but for some reason no page was created.
- User:そらみみ add a category a few hours later at 22:56 on December 30
6 month later User:JuTa add a "no license" and the script inform User:Taisuke.Kasuya. But the bot decide to also inform User:そらみみ. Its not a big deal just thought you should know. --MGA73 (talk) 15:06, 19 July 2020 (UTC)
- Unrelated to bot, there are some issues with the
databaseAPI. The quick deletion script similarly sometimes notify the wrong users. I don't think I can do anything about it. // Eatcha (talk) 17:52, 19 July 2020 (UTC)- Okay :-) I have no open issues so its a go from here! --MGA73 (talk) 07:35, 20 July 2020 (UTC)
I think most issues have been addressed, so this can be called approved now. --Krd 06:43, 21 July 2020 (UTC)