View source for Template talk:MilAward

==Testing the template==
=== Stats ===
{{Image frame 
 | caption= {{legend|darkgreen|Awards per country (Manual Graph)}}
 | pos=top 
 | content = {{Graph:Chart
 | width=600
 | height=200
 | xAxisTitle=Country
 | yAxisTitle=Total Awards
 | type=rect
 | showSymbols=
 | colors=darkgreen, darkred
 | xAxisAngle=-45
 | showValues=offset:5, fontcolor:Silver
| x=Africa, United Kingdom, Spain, Australia, Paraguay, Taiwan, Italy, Zimbabwe, Chile, Dummy, South Vietnam, Portugal, Canada, Argentina, Rhodesia, USA, South Africa, Ciskei, Great Britain, Brazil, USA, Belgium, France, United Nations, ROK, Unknown, Ottoman Empire, None 
| y= 1, 1, 9, 41, 1, 10, 2, 2, 9, 1, 1, 22, 1, 20, 46, 48, 236, 7, 88, 51, 2, 8, 21, 83, 7, 1, 6, 10
}}
}}
{{MilAward Stats}}

{{clear}}

{{Image frame 
 | caption= {{legend|darkgreen|Medal Recipients}}
 | pos=top 
 | content = {{Graph:Chart
 | width=600
 | height=200
 | xAxisTitle=Medal
 | yAxisTitle=Total entries
 | type=rect
 | showSymbols=
 | colors=darkgreen, darkred
 | xAxisAngle=-45
 | showValues=offset:5, fontcolor:Silver
 | x= Pro Patria,Star of SA (SSA), Southern Cross Decoration (SD), Police Star for Outstanding Service (SOE), Southern Cross Medal (SM), Military Merit Medal (MMM) , Order of the Cloud and Banner (ORB), iPhrothiya Medals (PG,PS,PB), Operational Medal for Southern Africa, MK South Africa Service Medal
 | y={{PAGESINCAT:Recipients of the Pro Patria Medal (South Africa)|R}},{{PAGESINCAT:Recipient of the Order of the Star of South Africa|R}}, {{PAGESINCAT:Recipients of the Southern Cross Decoration|R}}, {{PAGESINCAT:Recipients of the South African Police Star for Outstanding Service|R}}, {{PAGESINCAT:Recipients of the Southern Cross Medal|R}}, {{PAGESINCAT:Recipients of the Military Merit Medal (South Africa)|R}}, {{PAGESINCAT:Recipient of the Order of the Cloud and Banner|R}}, {{PAGESINCAT:Recipients of the iPhrothiya Medals|R}}, {{PAGESINCAT:Recipients of the Operational Medal for Southern Africa|R}}, {{PAGESINCAT:Recipients of the MK South Africa Service Medal|R}}
}}
}}
{{clear}}

=== Ribbons and Descriptions ===
* Ribbon : {{MilAward|MMM|x12px}}
* Description: {{#invoke:MilAward|RibbonDesc|MMM}}
* Description: {{#invoke:MilAward|RibbonDesc|DCSMMO}}
* Description: {{#invoke:MilAward|RibbonDesc|code=PB}}

* Test Ribbon 1
** Default: {{#invoke:MilAward|Ribbon|MMM}}
** Size {{#invoke:MilAward|Ribbon|MMM|x20px}}
* Test Ribbon 2
** {{#invoke:MilAward|Ribbon|PP}}
** {{#invoke:MilAward|Ribbon|PP|x12px}}
* Test Ribbon 3
** {{#invoke:MilAward|Ribbon|SED}}
** {{#invoke:MilAward|Ribbon|SED|x12px}}
* Test Ribbon 4
** <nowiki>{{MilAward|Ribbon|{{{1}}}}} </nowiki> {{em|Does not work. Needs the param filled in}}
** <nowiki>{{MilAward|Ribbon|{{{1}}}|x12px}}  </nowiki> {{em|Does not work. Needs the param filled in}}
** <nowiki>{{MilAward|Ribbon| |x12px}}  </nowiki> {{em|Does not work. Needs the param filled in}}
* Test Ribbon 5
** {{MilAward|DSO3|x25px}}
** {{MilAward|DSO3|x12px}}
* Test Description 1
** {{#invoke:MilAward|RibbonDesc|AFC**}}
** {{#invoke:MilAward|RibbonDesc|AFC**|x12px}}
* Test Description 2
** {{#invoke:MilAward|Ribbon|AFCxx|40px}}
** {{#invoke:MilAward|Ribbon|AFCxx|x12px}}
* Test Description 3
** {{#invoke:MilAward|RibbonDesc|SOO2}}
** {{#invoke:MilAward|RibbonDesc|SOO2|x12px}}

* test default size
** {{MilAward Ribbon|PP}}
** {{MilAward Desc|PP}}

=== Named Params ===
'''Note''': The named param does work but is not preferred
* Test 1: {{MilAward|{{{code|}}}}} {{em|Won't work because the code isn't provided}}
* Test 2: {{MilAward|code=MMM}} 
* Test 3: {{MilAward|code=PP}} 
* Test 4: {{#invoke:MilAward|Display|MMM}}
* Test 5: {{#invoke:MilAward|Display|PP}}
* Test 6: {{#invoke:MilAward|Ribbon|code=MMM}} 
* Test 7: {{#invoke:MilAward|RibbonDesc|code=PP}}

* Test 8: {{#invoke:MilAward|RibbonDesc|PP|norib=yes}}

== Making this work ==

So I am pretty much at the stage where I can now make this work. The bulk of the data is converted into the format that makes it available, and the basic routines (Ribbon and RibbonDesc) work pretty well. There are some tweaks to them which I'll tackle, but the basics are there. 
Now I need to decide what to do going forward. As I see it there are at least two competing options.
* Keep using {{tlx|Medal Display}} and <nowiki>{{Ribbon Display}}</nowiki>. Edit them to stop using local data but replace their current functionality with #evoke calls to my new Lua routines
* or, Write new templates (say for example {{tlx|MilAward Ribbon}} and {{tlx|MilAward RibbonDesc}} or something like that, then tidy everything up to replace the old templates with the new?

I also need someone to cast an eye at the data both in the table on the talk page as well as maybe directly in {{tlx|Module:MilAward/data}}  What I'm thinking is that I have made all sorts of decisions on my own and they might not be the best. For example what data we need to store etc. Take as an example the idea of "class". Run your eye down the list and you will see how I have used that field, which makes a lot of sense to me but might not to others. The other issue is "Country" and "Org". Do they make sense? Do we need an additional field maybe like "Type"? Ideas please. [[User:BoonDock|BoonDock]] ([[User talk:BoonDock|talk]]) 12:13, 6 April 2023 (UTC)

:Copying this from my user page as it's pertinent to the discussion:
:I wrote a [[WP:Lua|Lua]] module called {{tlx|Module:MilAward}} which holds all the data I can find for medals in {{tlx|Module:MilAward/data}}. This module implements a variety of functions which draw the data from that stored in {{tlx|Module:MilAward/data}} to present it in different ways. 
:I have created the following templates to present that data:
:* {{tlx|Template:MilAward}} - This defaults to the {{tlx|Template:MilAward Ribbon}} mentioned below - display the award ribbon linked to the medal information page
:To be created:
:* {{tlx|Template:MilAward Ribbon}} - {{done}} display the award ribbon linked to the medal information page
:* {{tlx|Template:MilAward Desc}} - {{done}} display the ribbon and alongside it the medal name with a link to the medal's page. Note, you can use the parameter "norip=yes" to only display the description
:* {{tld|MilAward Stats}} - {{done}} A subroutine which can be invoked to list all the data in the database. Currently active on {{tlx|Template talk:MilAward}} It can be invoked (#invoke) by anyone on any page, and if needed I will create a template for it. If I do create the template, I will remove the stat table.{{Not done|(Not for now anyway)}} Depends on someone making a use case. 
:* {{tlx|Template:MilAward PostNom}} - {{done}} a replacement for the {{tlx|Post-nominals}} template drawing from the same database.
:* {{tlx|Template:MilAward Stack}} - {{done}} This will allow for a list of medal codes, similar to the current Post-nominals template, which would then display all the ribbons specified in a long horizontal stack, similar to how the {{tlx|Template:MilAward Ribbon}} works now with individual ribbons.
:As I go, I will also add extra features:
:* Country=yes - Add the display of country to the medal description. WIll have to figure out if I display just what's in the data or do an ISO lookup for a country name. {{done}} This works this way. "country=ZAR" means that if the award does '''NOT''' match the country specified (ZAR), then add the display of the country to the award. 
:* Class=no - Allow the turning off of the addition of what's in the "Class" field to the medal description
:* TextSize=xx - Allow the specification of the size of the text. Probably a percentage.
:* Org=yes - Allow the turning on of the display of the contents of the "Org" field
:* Notes=no - Allow the turning off of the display of the contents of the "Notes" field
:* norib=yes - Turn off display of the Ribbon {{done}}
:* Allow the ability to add a "Recipient Category" for each medal {{done}}
:* Others ???
:[[User:BoonDock|BoonDock]] ([[User talk:BoonDock|talk]]) 15:55, 6 April 2023 (UTC)
:I've had a thought that if this ''does'' become too unwieldy with everything shoved into one module/data page, it's possible to write it to split the data modules. I don't '''want''' to do that, so I will avoid it as much as possible ;-) [[User:BoonDock|BoonDock]] ([[User talk:BoonDock|talk]]) 14:40, 7 April 2023 (UTC)

== Bogus file options lint errors ==

[[Template talk:MilAward]] (this page) has four [https://en.wikipedia.org/wiki/Special:LintErrors/bogus-image-options?namespace=11 Bogus file options] lint errors, each of which is <code><nowiki>{{{2}}}</nowiki></code>, and the errors are caused by by these markup snips:
* <code><nowiki>{{MilAward|MMM}}</nowiki></code>
* <code><nowiki>{{MilAward|DSO3}}</nowiki></code>
* <code><nowiki>{{MilAward|code=MMM}}</nowiki></code>
* <code><nowiki>{{MilAward|code=PP}}</nowiki></code>

The rest of the page is all lint-free. It would be good to fix the code so these work as intended, without lint. For those who don't know about lint errors, see [[WP:Linter]]. For those who want to work on fixing lint errors, you are encouraged to install lintHint as described on that page. —[[User:Anomalocaris|Anomalocaris]] ([[User talk:Anomalocaris|talk]]) 07:02, 11 April 2023 (UTC)

:Hi, Thanks for pointing that out. They were done deliberately while I test this template and the Lua module. [[User:BoonDock|BoonDock]] ([[User talk:BoonDock|talk]]) 17:49, 11 April 2023 (UTC)
:Just FYI, I think I have fixed the errors now. I was concentrating on searching for the bug in my Lua code. Turns out the solution was to add a default option as part of the template params. Please let me know if you see the bug again. [[User:BoonDock|BoonDock]] ([[User talk:BoonDock|talk]]) 01:29, 14 April 2023 (UTC)

== DescList ==
=== DescList Test ===
{{suppress categories|{{#invoke:MilAward|DescList|x25px|AFC|PP|MMM}}}} 
=== PostNom Test ===
{{suppress categories|{{#invoke:MilAward|PostNom|x25px|AFC|PP|MMM}}}}
=== Stack Test ===
* {{#invoke:MilAward|Stack|size=x50px|AFC|PP|MMM}}  (Large, specify size)
* {{#invoke:MilAward|Stack|AFC|PP|MMM}}  (Default size)
* {{#invoke:MilAward|Stack|size=x6px|AFC|PP|MMM}} 

[[User:BoonDock|BoonDock]] ([[User talk:BoonDock|talk]]) 17:56, 13 April 2023 (UTC)