fix(pubsub): add attributes before startSpan #10800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Attributes can be used for sampling and so they should be added before span creation, if possible. See [1]. [1] https://opentelemetry.io/docs/concepts/signals/traces/#attributes
jameshartig
force-pushed
the
x-pubsub-span-attrs-before-creation
branch
from
c8520d8
to
bc476e4
Compare
hongalex
approved these changes
Sep 5, 2024
kokoro-team
removed
the
kokoro:run
|
Thanks for creating this PR! This will be part of the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes can be used for sampling and so they should be added before span creation, if possible. See [1].
We had an configuration AST that lets us set the sample rate based on the span attributes but it requires the span attributes to be sent to the create span so they can be used for sampling. In particular we wanted to increase the sample rate for
code.function: receiveso we could help debug the recent redelivery issues.[1] https://opentelemetry.io/docs/concepts/signals/traces/#attributes
/cc @hongalex