Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Read RPC OrderBy #3180

Merged
merged 1 commit into from
Jul 12, 2024
Merged

feat: support Read RPC OrderBy #3180

merged 1 commit into from
Jul 12, 2024

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Jun 27, 2024

Adds support for setting Read OrderBy.

Customers can set this option only for the Read API. This option will allow users to specify whether they want the results to be returned in primary key order (PRIMARY_KEY) or in an out of order (NO_ORDER). The NO_ORDER is significantly faster than KEY_ORDER, because spanner uses higher parallelism for non-ordered reads.

Go counterpart: googleapis/google-cloud-go#10289

@mayurkale22 mayurkale22 requested a review from a team as a code owner June 27, 2024 04:14
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 27, 2024
@harshachinta
Copy link
Contributor

@mayurkale22
Looks like the sample added in the PR description is for Golang. Can we move this sample to the Go PR - googleapis/google-cloud-go#10289?

@mayurkale22
Copy link
Member Author

@mayurkale22 Looks like the sample added in the PR description is for Golang. Can we move this sample to the Go PR - googleapis/google-cloud-go#10289?

Done

@mayurkale22
Copy link
Member Author

@harshachinta Can you pls review this PR?

@rahul2393 rahul2393 merged commit 735bca5 into googleapis:main Jul 12, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants