Page MenuHomePhabricator
Create Task
Maniphest T217244

Column layout breaks in Chrome when using Emoji
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Using emoji in aliases (possibly also labels an descriptions) breaks the width of the columns in Chrome. It seems that the problem does not appear in other browsers.

Screenshot from 2019-02-27 15-12-55.png (611×1 px, 86 KB)

See e.g. https://wikidata.beta.wmflabs.org/wiki/Q515698?useformat=mobile
Possibly related: https://stackoverflow.com/questions/42016125/emoji-rendered-in-chrome-have-different-widths-than-in-other-browsers

Details

SubjectRepoBranchLines +/-
Update termboxmediawiki/extensions/Wikibasemaster+1 -1
shrinking-flex-element: add mixinwikibase/termboxmaster+17 -5
Fix broken word-wrapwikibase/termboxmaster+10 -9
Enforce term flex item widths in column layoutwikibase/termboxmaster+5 -4
termbox: pin latest changesmediawiki/extensions/Wikibasemaster+1 -1
Alias: overcome chrome flex width challengewikibase/termboxmaster+9 -2
Customize query in gerrit

Event Timeline

Jakob_WMDE created this task.Feb 27 2019, 2:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2019, 2:14 PM
Jakob_WMDE added projects: Wikidata, Wikidata-Termbox.Feb 27 2019, 2:15 PM
Jakob_WMDE awarded a token.Feb 27 2019, 2:18 PM
WMDE-leszek set the point value for this task to 2.Feb 27 2019, 3:58 PM
• Lea_WMDE moved this task from Backlog to MVP things: Ready for pickup on the Wikidata-Termbox board.Feb 27 2019, 4:22 PM
gerritbot subscribed.Feb 27 2019, 4:44 PM

Change 493274 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] Alias: overcome chrome flex width challenge

https://gerrit.wikimedia.org/r/493274

gerritbot added a project: Patch-For-Review.Feb 27 2019, 4:44 PM
gerritbot added a comment.Feb 28 2019, 3:35 PM

Change 493274 merged by jenkins-bot:
[wikibase/termbox@master] Alias: overcome chrome flex width challenge

https://gerrit.wikimedia.org/r/493274

• Pablo-WMDE edited projects, added Wikidata-Termbox-Iteration-10; removed Wikidata-Termbox.Mar 1 2019, 9:26 AM
• Pablo-WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-10 board.
• Pablo-WMDE added a subscriber: Wikidata-Termbox-Iteration-10.
• Pablo-WMDE removed a subscriber: Wikidata-Termbox-Iteration-10.
gerritbot added a comment.Mar 1 2019, 11:02 AM

Change 493665 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: pin latest changes

https://gerrit.wikimedia.org/r/493665

gerritbot added a comment.Mar 1 2019, 1:50 PM

Change 493665 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: pin latest changes

https://gerrit.wikimedia.org/r/493665

• Pablo-WMDE added subscribers: Lea_Lacroix_WMDE, • Pablo-WMDE.Mar 1 2019, 2:26 PM

This is now fixed and on beta: https://wikidata.beta.wmflabs.org/wiki/Q515698?useformat=mobile (mind the browser cache)

/cc @Lea_Lacroix_WMDE

• Pablo-WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Termbox-Iteration-10 board.Mar 1 2019, 2:26 PM
• Pablo-WMDE moved this task from Test (Product Review) to To Do on the Wikidata-Termbox-Iteration-10 board.Mar 1 2019, 2:35 PM

The inline-block solution used in https://gerrit.wikimedia.org/r/493665 breaks the hyphens/wrapping in place.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 5 2019, 2:04 PM
• Lea_WMDE added a project: Wikidata-Termbox-Iteration-11.Mar 11 2019, 2:13 PM
gerritbot added a comment.Mar 12 2019, 10:48 AM

Change 495865 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Fix broken word-wrap

https://gerrit.wikimedia.org/r/495865

• Matthias_Geisler_WMDE claimed this task.Mar 12 2019, 10:49 AM
• Matthias_Geisler_WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-11 board.
gerritbot added a comment.Mar 12 2019, 11:59 AM

Change 495874 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Enforce flex item widths

https://gerrit.wikimedia.org/r/495874

gerritbot added a comment.Mar 12 2019, 4:13 PM

Change 495874 merged by jenkins-bot:
[wikibase/termbox@master] Enforce term flex item widths in column layout

https://gerrit.wikimedia.org/r/495874

gerritbot added a comment.Mar 12 2019, 5:38 PM

Change 495946 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] shirinking-flex-element: add mixin

https://gerrit.wikimedia.org/r/495946

gerritbot added a comment.Mar 13 2019, 9:02 AM

Change 495865 abandoned by Matthias Geisler:
Fix broken word-wrap

Reason:
done by https://gerrit.wikimedia.org/r/#/c/wikibase/termbox/ /495874/

https://gerrit.wikimedia.org/r/495865

gerritbot added a comment.Mar 13 2019, 11:05 AM

Change 495946 merged by jenkins-bot:
[wikibase/termbox@master] shrinking-flex-element: add mixin

https://gerrit.wikimedia.org/r/495946

gerritbot added a comment.Mar 13 2019, 12:35 PM

Change 496152 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Update termbox

https://gerrit.wikimedia.org/r/496152

gerritbot added a comment.Mar 13 2019, 7:09 PM

Change 496152 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update termbox

https://gerrit.wikimedia.org/r/496152

• Pablo-WMDE added a comment.Mar 14 2019, 11:19 AM

This is now fixed. Please see https://wikidata.beta.wmflabs.org/wiki/Q515698?useformat=mobile

• Pablo-WMDE removed • Matthias_Geisler_WMDE as the assignee of this task.Mar 14 2019, 11:19 AM
• Pablo-WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Termbox-Iteration-11 board.
• Pablo-WMDE added a subscriber: • Matthias_Geisler_WMDE.
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.22; 2019-03-19); removed MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 17 2019, 2:05 AM
• Lea_WMDE closed this task as Resolved.Mar 19 2019, 1:32 PM
• Lea_WMDE claimed this task.
• Lea_WMDE moved this task from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-11 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits