Page MenuHomePhabricator

Failed reference rendering keeps bridge in limbo forever
Closed, ResolvedPublicBUG REPORT

Description

Current behavior:
Reference rendering ( renderReferences action) is currently not covered by our custom error handling - if there is an error or a lack of response (which eventually results in a timeout error), the initBridgeWithRemoteData throws an exception (by virtue of await), but this is never converted to an application error.

Expected behavior:
Show bridge anyway but without the references if their rendering failed for any reason.

Technical note:

  • can easily by achieved by a breakpoint in ApiFormatReference which is kept for 30sec+

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 599311 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: ignore if reference rendering fails

https://gerrit.wikimedia.org/r/599311

It's definitely not nice not to show the references but I think in this case it's preferable to showing an error. So let's go with not showing the references.

Change 599311 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: ignore if reference rendering fails

https://gerrit.wikimedia.org/r/599311