Page MenuHomePhabricator
Create Task
Maniphest T65424

Remove uses of Title::newFromURL
Open, LowPublic
Actions

Description

As per @TTO:

There are a few uses of Title::newFromURL left:

  • MediaWiki core includes/MediaWiki.php. This one is going to be very difficult to get rid of, as it is on the critical path for almost all index.php requests (it's used to convert the title= parameter into $wgTitle). There are subtle effects here that may result in URL breakages.
  • MediaWiki core includes/parser/CoreParserFunctions.php and Scribunto UrlLibrary. These seem to be used for handling user input (parameter to a parser function and a Lua function respectively) so are going to be more difficult to remove.
  • Something in FlaggedRevs
Usage

https://codesearch.wmflabs.org/search/?q=Title%3A%3AnewFromURL&i=nope&files=&repos=

Details

Reference
bz63424
Show related patches Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:08 AM
• bzimport added projects: MediaWiki-General, good first task.
• bzimport set Reference to bz63424.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Apr 2 2014, 3:36 PM
Aklapper added a comment.Nov 13 2014, 1:03 PM

(In reply to Daniel Norton from comment #0)

If that's accurate, then there's some code that needs fixing.

Would love to have some confirmation in this ticket from some core developers.

TTO added a project: Google-Code-In-2015.Nov 17 2015, 9:46 AM
TTO subscribed.

I'll mentor this.

Most instances of this function, particularly in the special pages where the user input is coming out of getRequest()->getText(), can simply be replaced with Title::newFromText, but we will need to check them carefully.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2015, 9:46 AM
Aklapper added a comment.Dec 3 2015, 6:45 PM

https://codein.withgoogle.com/dashboard/tasks/4718021977309184/

Aklapper moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 3 2015, 6:45 PM
gerritbot subscribed.Dec 11 2015, 9:52 PM

Change 258524 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258524

gerritbot added a project: Patch-For-Review.Dec 11 2015, 9:52 PM
gerritbot added a comment.Dec 11 2015, 10:32 PM

Change 258536 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258536

gerritbot added a comment.Dec 11 2015, 10:40 PM

Change 258537 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258537

gerritbot added a comment.Dec 11 2015, 10:44 PM

Change 258538 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258538

gerritbot added a comment.Dec 11 2015, 10:53 PM

Change 258594 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258594

gerritbot added a comment.Dec 11 2015, 10:55 PM

Change 258613 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258613

gerritbot added a comment.Dec 11 2015, 10:58 PM

Change 258625 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258625

gerritbot added a comment.Dec 11 2015, 11:00 PM

Change 258627 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258627

gerritbot added a comment.Dec 11 2015, 11:04 PM

Change 258628 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258628

gerritbot added a comment.Dec 11 2015, 11:07 PM

Change 258629 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258629

gerritbot added a comment.Dec 11 2015, 11:08 PM

Change 258630 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258630

gerritbot added a comment.Dec 11 2015, 11:10 PM

Change 258632 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258632

gerritbot added a comment.Dec 11 2015, 11:20 PM

Change 258636 had a related patch set uploaded (by Albert221):
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258636

gerritbot added a comment.Dec 12 2015, 1:03 AM

Change 258625 merged by jenkins-bot:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258625

gerritbot added a comment.Dec 12 2015, 1:19 AM

Change 258632 merged by jenkins-bot:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258632

gerritbot added a comment.Dec 12 2015, 1:19 AM

Change 258537 merged by jenkins-bot:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258537

gerritbot added a comment.Dec 12 2015, 1:26 AM

Change 258630 merged by jenkins-bot:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258630

gerritbot added a comment.Dec 12 2015, 1:32 AM

Change 258636 merged by jenkins-bot:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258636

gerritbot added a comment.Dec 12 2015, 1:32 AM

Change 258628 merged by jenkins-bot:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258628

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 12 2015, 2:00 AM
gerritbot added a comment.Dec 12 2015, 6:01 AM

Change 258627 merged by jenkins-bot:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258627

gerritbot added a comment.Dec 12 2015, 6:18 AM

Change 258629 merged by jenkins-bot:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258629

gerritbot added a comment.Dec 12 2015, 11:05 AM

Change 258536 abandoned by Albert221:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258536

gerritbot added a comment.Dec 12 2015, 11:12 AM

Change 258538 merged by jenkins-bot:
Replace Title::newFromURL with Title::newFromText

https://gerrit.wikimedia.org/r/258538

gerritbot added a comment.Dec 12 2015, 11:25 AM

Change 258524 merged by jenkins-bot:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258524

gerritbot added a comment.Dec 12 2015, 11:25 AM

Change 258594 merged by jenkins-bot:
Resolve code invoking Title::newFromURL

https://gerrit.wikimedia.org/r/258594

TTO added a subscriber: Albert221.Dec 12 2015, 11:36 AM

As you can see, GCI student @Albert221 did an awesome amount of work to reduce uses of this function.

There are a few uses of Title::newFromURL left:

  • MediaWiki core includes/MediaWiki.php. This one is going to be very difficult to get rid of, as it is on the critical path for almost all index.php requests (it's used to convert the title= parameter into $wgTitle). There are subtle effects here that may result in URL breakages.
  • MediaWiki core includes/parser/CoreParserFunctions.php and Scribunto UrlLibrary. These seem to be used for handling user input (parameter to a parser function and a Lua function respectively) so are going to be more difficult to remove.
  • Something in FlaggedRevs that I couldn't understand.
TTO removed a project: good first task.Dec 12 2015, 11:37 AM
TTO set Security to None.
TTO removed a subscriber: • wikibugs-l-list.
ReleaseTaggerBot added a project: MW-1.27-release-notes.Dec 12 2015, 12:00 PM
gerritbot added a comment.Dec 12 2015, 10:25 PM

Change 258613 abandoned by TTO:
Resolve code invoking Title::newFromURL

Reason:
Per Jack, I guess the best thing to do is to leave this repo alone for now.

https://gerrit.wikimedia.org/r/258613

Mvolz renamed this task from Resolve "wrong and broken code" that's invoking Title::newFromURL to Remove uses of Title::newFromURL.Oct 28 2016, 1:15 PM
Mvolz updated the task description. (Show Details)
Mvolz removed a project: Patch-For-Review.
xSavitar updated the task description. (Show Details)Aug 4 2019, 10:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits