You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PinotDriver.connect() method leaks the PinotClientTransport and PinotControllerTransport when an exception is thrown trying to construct the PinotConnection. This highly impacts applications that utilize other drivers, and eventually causes the server which has registered the driver to crash.
Suggested solution:
Convert PinotClientTransport and PinotControllerTransport to temporary variables, and close them individually, and safely, when exceptions are thrown getting the connection. Like so:
Add a URL check to return null if the URL is not expected, avoiding allocating resources altogether if not necessary.
Like so: if (!this.acceptsURL(url)) { return null; }
The text was updated successfully, but these errors were encountered:
The PinotDriver.connect() method leaks the PinotClientTransport and PinotControllerTransport when an exception is thrown trying to construct the PinotConnection. This highly impacts applications that utilize other drivers, and eventually causes the server which has registered the driver to crash.
Suggested solution:
Like so:
if (!this.acceptsURL(url)) { return null; }
The text was updated successfully, but these errors were encountered: