Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First with time #12235

Merged
merged 29 commits into from
Mar 20, 2024
Merged

First with time #12235

merged 29 commits into from
Mar 20, 2024

Conversation

gortiz
Copy link
Contributor

@gortiz gortiz commented Jan 8, 2024

Like #12227 but adding support for FIRST_WITH_TIME.

This PR should not be merged before #12215

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 287 lines in your changes are missing coverage. Please review.

Project coverage is 27.74%. Comparing base (59551e4) to head (02a6464).
Report is 137 commits behind head on master.

Files Patch % Lines
...nction/NullableSingleInputAggregationFunction.java 0.00% 46 Missing ⚠️
...ion/function/FirstWithTimeAggregationFunction.java 0.00% 40 Missing ⚠️
...n/FirstDoubleValueWithTimeAggregationFunction.java 0.00% 17 Missing ⚠️
...on/FirstFloatValueWithTimeAggregationFunction.java 0.00% 17 Missing ⚠️
...tion/FirstIntValueWithTimeAggregationFunction.java 0.00% 17 Missing ⚠️
...ion/FirstLongValueWithTimeAggregationFunction.java 0.00% 17 Missing ⚠️
...n/FirstStringValueWithTimeAggregationFunction.java 0.00% 17 Missing ⚠️
...on/LastDoubleValueWithTimeAggregationFunction.java 0.00% 17 Missing ⚠️
...ion/LastFloatValueWithTimeAggregationFunction.java 0.00% 17 Missing ⚠️
...ction/LastIntValueWithTimeAggregationFunction.java 0.00% 17 Missing ⚠️
... and 5 more
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12235       +/-   ##
=============================================
- Coverage     61.75%   27.74%   -34.02%     
+ Complexity      207      198        -9     
=============================================
  Files          2436     2452       +16     
  Lines        133233   133870      +637     
  Branches      20636    20742      +106     
=============================================
- Hits          82274    37136    -45138     
- Misses        44911    93890    +48979     
+ Partials       6048     2844     -3204     
Flag Coverage Δ
custom-integration1 ?
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 27.73% <0.00%> (-33.98%) ⬇️
java-21 <0.01% <0.00%> (-61.63%) ⬇️
skip-bytebuffers-false 27.74% <0.00%> (-34.01%) ⬇️
skip-bytebuffers-true <0.01% <0.00%> (-27.73%) ⬇️
temurin 27.74% <0.00%> (-34.02%) ⬇️
unittests 27.73% <0.00%> (-34.02%) ⬇️
unittests1 ?
unittests2 27.73% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gortiz gortiz merged commit cb3ccdc into apache:master Mar 20, 2024
19 checks passed
@gortiz gortiz deleted the first-with-time branch March 20, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants