Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minmaxrange null #12252

Merged
merged 23 commits into from
Mar 19, 2024
Merged

Minmaxrange null #12252

merged 23 commits into from
Mar 19, 2024

Conversation

gortiz
Copy link
Contributor

@gortiz gortiz commented Jan 10, 2024

Adds null support for minmaxrange operation. It assumes #12215 is already merged

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 61.44%. Comparing base (59551e4) to head (dfd4e92).
Report is 144 commits behind head on master.

Files Patch % Lines
...ation/function/MinMaxRangeAggregationFunction.java 77.27% 8 Missing and 2 partials ⚠️
...ot/segment/local/customobject/MinMaxRangePair.java 0.00% 4 Missing ⚠️
...t/local/aggregator/MinMaxRangeValueAggregator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12252      +/-   ##
============================================
- Coverage     61.75%   61.44%   -0.32%     
+ Complexity      207      192      -15     
============================================
  Files          2436     2452      +16     
  Lines        133233   133857     +624     
  Branches      20636    20756     +120     
============================================
- Hits          82274    82244      -30     
- Misses        44911    45455     +544     
- Partials       6048     6158     +110     
Flag Coverage Δ
custom-integration1 ?
integration 0.00% <0.00%> (-0.01%) ⬇️
integration1 ?
integration2 0.00% <0.00%> (ø)
java-11 61.40% <70.58%> (-0.31%) ⬇️
java-21 34.52% <70.58%> (-27.10%) ⬇️
skip-bytebuffers-false 61.44% <70.58%> (-0.31%) ⬇️
skip-bytebuffers-true 0.00% <0.00%> (-27.73%) ⬇️
temurin 61.44% <70.58%> (-0.32%) ⬇️
unittests 61.44% <70.58%> (-0.31%) ⬇️
unittests1 46.36% <70.58%> (-0.53%) ⬇️
unittests2 27.73% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gortiz gortiz merged commit d12ce88 into apache:master Mar 19, 2024
19 checks passed
@gortiz gortiz deleted the minmaxrange_null branch March 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants