-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Percentile operations supporting null #12271
Conversation
…pport null handling
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12271 +/- ##
=============================================
- Coverage 61.75% 0.00% -61.75%
+ Complexity 207 6 -201
=============================================
Files 2436 2377 -59
Lines 133233 130276 -2957
Branches 20636 20189 -447
=============================================
- Hits 82274 6 -82268
- Misses 44911 130270 +85359
+ Partials 6048 0 -6048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
} else { | ||
// Create a new QuantileDigest for the group | ||
groupByResultHolder.setValueForKey(groupKey, | ||
ObjectSerDeUtils.QUANTILE_DIGEST_SER_DE.deserialize(bytesValues[i])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Jackie-Jiang There is a very strange thing here: I've tried to change this line to
groupByResultHolder.setValueForKey(groupKey, value);
but it randomly fails in testInnerSegmentGroupByMV
. AFAIU ObjectSerDeUtils.QUANTILE_DIGEST_SER_DE.deserialize(bytesValues[i])
should be pure and nobody should have changed bytesValues[i]
. Do you see where is the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version that fails is in previous commit (6837c41), which was tested in https://github.com/apache/pinot/actions/runs/8326646341/job/22782753708
Like #12227 but adding support for PERCENTILE, PERCENTILE_SMARTTDIGEST, PERCENTILE_EST, PERCENTILE_RAWEST, PERCENTILE_KLL, PERCENTILE_RAWKLL,
This PR should not be merged before #12215