Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentile operations supporting null #12271

Merged
merged 25 commits into from
Apr 1, 2024
Merged

Conversation

gortiz
Copy link
Contributor

@gortiz gortiz commented Jan 16, 2024

Like #12227 but adding support for PERCENTILE, PERCENTILE_SMARTTDIGEST, PERCENTILE_EST, PERCENTILE_RAWEST, PERCENTILE_KLL, PERCENTILE_RAWKLL,

This PR should not be merged before #12215

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 222 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (ce34f92).
Report is 144 commits behind head on master.

Files Patch % Lines
...ion/function/PercentileEstAggregationFunction.java 0.00% 46 Missing ⚠️
...function/PercentileTDigestAggregationFunction.java 0.00% 44 Missing ⚠️
...ion/PercentileSmartTDigestAggregationFunction.java 0.00% 42 Missing ⚠️
...ion/function/PercentileKLLAggregationFunction.java 0.00% 33 Missing ⚠️
...gation/function/PercentileAggregationFunction.java 0.00% 27 Missing ⚠️
...gregation/function/AggregationFunctionFactory.java 0.00% 15 Missing ⚠️
...ction/PercentileRawTDigestAggregationFunction.java 0.00% 3 Missing ⚠️
...nction/PercentileTDigestMVAggregationFunction.java 0.00% 3 Missing ⚠️
...n/function/PercentileEstMVAggregationFunction.java 0.00% 2 Missing ⚠️
...tion/function/PercentileMVAggregationFunction.java 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12271       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.75%     
+ Complexity      207        6      -201     
=============================================
  Files          2436     2377       -59     
  Lines        133233   130276     -2957     
  Branches      20636    20189      -447     
=============================================
- Hits          82274        6    -82268     
- Misses        44911   130270    +85359     
+ Partials       6048        0     -6048     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 <0.01% <0.00%> (-61.71%) ⬇️
java-21 0.00% <0.00%> (-61.63%) ⬇️
skip-bytebuffers-false <0.01% <0.00%> (-61.75%) ⬇️
skip-bytebuffers-true 0.00% <0.00%> (-27.73%) ⬇️
temurin <0.01% <0.00%> (-61.75%) ⬇️
unittests ?
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

} else {
// Create a new QuantileDigest for the group
groupByResultHolder.setValueForKey(groupKey,
ObjectSerDeUtils.QUANTILE_DIGEST_SER_DE.deserialize(bytesValues[i]));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Jackie-Jiang There is a very strange thing here: I've tried to change this line to

groupByResultHolder.setValueForKey(groupKey, value);

but it randomly fails in testInnerSegmentGroupByMV. AFAIU ObjectSerDeUtils.QUANTILE_DIGEST_SER_DE.deserialize(bytesValues[i]) should be pure and nobody should have changed bytesValues[i]. Do you see where is the difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version that fails is in previous commit (6837c41), which was tested in https://github.com/apache/pinot/actions/runs/8326646341/job/22782753708

@gortiz gortiz changed the title Percentille operations supporting null Percentile operations supporting null Mar 22, 2024
@gortiz gortiz merged commit c15c391 into apache:master Apr 1, 2024
19 checks passed
@gortiz gortiz deleted the percentille-null branch April 1, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants