Bug fix: Do not ignore scheme property in Java client #12332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhd336
approved these changes
Jan 29, 2024
walterddr
reviewed
Jan 31, 2024
Comment on lines
+88
to
91
| String scheme = properties.getProperty("scheme", CommonConstants.HTTP_PROTOCOL); | ||
| if (_scheme == null || !_scheme.contentEquals(scheme)) { | ||
| _scheme = scheme; | ||
| } |
There was a problem hiding this comment.
this is equivalent to setting directly right?
_scheme = properties.getProperty("scheme", CommonConstants.HTTP_PROTOCOL);
in what scenarios is this not true?
There was a problem hiding this comment.
When someone is using Java Client in their code and do not use the builder pattern, the scheme:https property never gets enforced
There was a problem hiding this comment.
i dont understand. the code is literally setting the class variable _schema to the property value schema.
In any cases the schema variable is different from _schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheme property already has a default value of
httpwhen initialised. This leads to a bug where we always ignore when a scheme is set using properties.