Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interning for OnHeapByteDictionary #12342

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

vvivekiyer
Copy link
Contributor

@vvivekiyer vvivekiyer marked this pull request as ready for review February 15, 2024 23:12
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d501478) 61.67% compared to head (a9af3e2) 61.74%.
Report is 43 commits behind head on master.

Files Patch % Lines
.../segment/index/dictionary/DictionaryIndexType.java 40.00% 4 Missing and 2 partials ⚠️
...ain/java/org/apache/pinot/spi/utils/ByteArray.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12342      +/-   ##
============================================
+ Coverage     61.67%   61.74%   +0.06%     
  Complexity      207      207              
============================================
  Files          2422     2436      +14     
  Lines        132148   133138     +990     
  Branches      20385    20619     +234     
============================================
+ Hits          81502    82202     +700     
- Misses        44660    44896     +236     
- Partials       5986     6040      +54     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.70% <80.95%> (+0.08%) ⬆️
java-21 61.62% <80.95%> (+0.06%) ⬆️
skip-bytebuffers-false 61.73% <80.95%> (+0.06%) ⬆️
skip-bytebuffers-true 61.60% <80.95%> (+0.06%) ⬆️
temurin 61.74% <80.95%> (+0.06%) ⬆️
unittests 61.73% <80.95%> (+0.06%) ⬆️
unittests1 46.88% <69.04%> (+0.04%) ⬆️
unittests2 27.72% <11.90%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang added documentation Configuration Config changes (addition/deletion/change in behavior) labels Apr 1, 2024
@vvivekiyer vvivekiyer merged commit 6290bc0 into apache:master Jun 6, 2024
19 checks passed
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
* Interning - OnHeapByteDictionary

* Address review comments from PR 12223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Config changes (addition/deletion/change in behavior) documentation performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants