Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up arbitrary sleep in GrpcBrokerClusterIntegrationTest #12379

Merged

Conversation

dttung2905
Copy link
Contributor

I came across this while trying to get familarise with the code base.

Parf ot the #7839

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cad8c56) 61.66% compared to head (38c9c5b) 61.72%.
Report is 31 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12379      +/-   ##
============================================
+ Coverage     61.66%   61.72%   +0.06%     
+ Complexity     1150      207     -943     
============================================
  Files          2426     2426              
  Lines        132776   132776              
  Branches      20541    20541              
============================================
+ Hits          81874    81959      +85     
+ Misses        44884    44804      -80     
+ Partials       6018     6013       -5     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (ø)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (?)
java-11 61.69% <ø> (+0.03%) ⬆️
java-21 61.58% <ø> (+33.87%) ⬆️
skip-bytebuffers-false 61.71% <ø> (+0.05%) ⬆️
skip-bytebuffers-true 61.57% <ø> (+33.86%) ⬆️
temurin 61.72% <ø> (+0.06%) ⬆️
unittests 61.72% <ø> (+0.06%) ⬆️
unittests1 46.88% <ø> (+0.05%) ⬆️
unittests2 27.73% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 merged commit 9f57e17 into apache:master Feb 20, 2024
19 checks passed
@dttung2905 dttung2905 deleted the cleanup-grpcbrokerclusteringtegrationtest branch February 20, 2024 14:27
@Jackie-Jiang
Copy link
Contributor

This is incorrect. We need to wait for all segments to be loaded. @dttung2905 @xiangfu0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants