Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bytes/string data type integration tests #12387

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Feb 9, 2024

For string bytes conversion

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2b69d6a) 61.74% compared to head (e31ddc7) 61.74%.
Report is 3 commits behind head on master.

Files Patch % Lines
.../pinot/common/function/scalar/StringFunctions.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12387      +/-   ##
============================================
- Coverage     61.74%   61.74%   -0.01%     
  Complexity      207      207              
============================================
  Files          2425     2428       +3     
  Lines        132766   132827      +61     
  Branches      20535    20545      +10     
============================================
+ Hits          81980    82012      +32     
- Misses        44771    44799      +28     
- Partials       6015     6016       +1     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.69% <0.00%> (+0.01%) ⬆️
java-21 61.60% <0.00%> (-0.03%) ⬇️
skip-bytebuffers-false 61.71% <0.00%> (-0.02%) ⬇️
skip-bytebuffers-true 61.58% <0.00%> (-0.01%) ⬇️
temurin 61.74% <0.00%> (-0.01%) ⬇️
unittests 61.73% <0.00%> (-0.01%) ⬇️
unittests1 46.90% <0.00%> (+<0.01%) ⬆️
unittests2 27.73% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 force-pushed the bytes-string-type-integration-test branch from 7dd4e0a to e31ddc7 Compare February 9, 2024 09:16
Copy link
Contributor

@KKcorps KKcorps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KKcorps KKcorps merged commit 04dd579 into apache:master Feb 14, 2024
19 checks passed
@xiangfu0 xiangfu0 deleted the bytes-string-type-integration-test branch February 14, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants