Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support of insecure TLS #12416

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

soumitra-st
Copy link
Contributor

@soumitra-st soumitra-st commented Feb 14, 2024

feature

How to use

What is insecure mode - curl -k

insecure mode is disabled by default, and the property to enable is .insecure=true
TlsUtils.createTrustManagerFactory method creates an instance of trust manager factory according to the insecure mode.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9321eab) 61.76% compared to head (0a4c98e) 61.78%.
Report is 2 commits behind head on master.

Files Patch % Lines
...n/java/org/apache/pinot/common/utils/TlsUtils.java 0.00% 6 Missing ⚠️
...java/org/apache/pinot/common/config/TlsConfig.java 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12416      +/-   ##
============================================
+ Coverage     61.76%   61.78%   +0.01%     
  Complexity      207      207              
============================================
  Files          2436     2436              
  Lines        133098   133106       +8     
  Branches      20617    20617              
============================================
+ Hits          82214    82236      +22     
+ Misses        44838    44824      -14     
  Partials       6046     6046              
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.72% <10.00%> (+0.01%) ⬆️
java-21 61.66% <10.00%> (+0.01%) ⬆️
skip-bytebuffers-false 61.74% <10.00%> (+<0.01%) ⬆️
skip-bytebuffers-true 61.63% <10.00%> (+0.03%) ⬆️
temurin 61.78% <10.00%> (+0.01%) ⬆️
unittests 61.77% <10.00%> (+0.01%) ⬆️
unittests1 46.90% <10.00%> (+0.01%) ⬆️
unittests2 27.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soumitra-st soumitra-st changed the title Adding support to create insecure TLS Adding support of insecure TLS Feb 14, 2024
@Jackie-Jiang Jackie-Jiang merged commit 38d86b0 into apache:master Feb 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants