-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: maven no transfer progress #12444
cleanup: maven no transfer progress #12444
Conversation
23abd3f
to
c3b5626
Compare
WDYT @xiangfu0 |
cc: @gortiz |
c3b5626
to
cc2b635
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12444 +/- ##
=========================================
Coverage 61.72% 61.73%
Complexity 207 207
=========================================
Files 2436 2436
Lines 133219 133219
Branches 20635 20635
=========================================
+ Hits 82233 82246 +13
+ Misses 44940 44925 -15
- Partials 6046 6048 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Does it actually affects anything? From maven docs it says:
We actually run in batch mode (see the |
cc2b635
to
1937101
Compare
when I run this command:
the output includes the download of each individual jar file:
When I run the same command with the "ntp" option
the output does not include any of the "download" messages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logs printed while building the project are reduced by about half (4000+ to 2000+). I'm good with the change, thanks!
Maven ntp ( 'no transfer progress' ) reduces the amount of Maven output in the CI build.