Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: maven no transfer progress #12444

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Feb 19, 2024

Maven ntp ( 'no transfer progress' ) reduces the amount of Maven output in the CI build.

@sullis sullis force-pushed the sean/maven-no-transfer-progress branch from 23abd3f to c3b5626 Compare February 21, 2024 19:25
@sullis
Copy link
Contributor Author

sullis commented Feb 21, 2024

WDYT @xiangfu0

@sullis
Copy link
Contributor Author

sullis commented Feb 22, 2024

cc: @gortiz

@sullis sullis force-pushed the sean/maven-no-transfer-progress branch from c3b5626 to cc2b635 Compare February 23, 2024 01:13
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.73%. Comparing base (fe75309) to head (1937101).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #12444   +/-   ##
=========================================
  Coverage     61.72%   61.73%           
  Complexity      207      207           
=========================================
  Files          2436     2436           
  Lines        133219   133219           
  Branches      20635    20635           
=========================================
+ Hits          82233    82246   +13     
+ Misses        44940    44925   -15     
- Partials       6046     6048    +2     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (ø)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 61.67% <ø> (-0.01%) ⬇️
java-21 61.59% <ø> (-0.02%) ⬇️
skip-bytebuffers-false 61.69% <ø> (-0.02%) ⬇️
skip-bytebuffers-true 61.58% <ø> (-0.01%) ⬇️
temurin 61.73% <ø> (+<0.01%) ⬆️
unittests 61.73% <ø> (+<0.01%) ⬆️
unittests1 46.86% <ø> (+<0.01%) ⬆️
unittests2 27.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gortiz
Copy link
Contributor

gortiz commented Feb 23, 2024

Does it actually affects anything? From maven docs it says:

Maven has now a an option to suppress the transfer progress when downloading/uploading in interactive mode.

We actually run in batch mode (see the -B) so there shouldn't be an actual difference, right?

@sullis sullis force-pushed the sean/maven-no-transfer-progress branch from cc2b635 to 1937101 Compare February 23, 2024 17:38
@sullis
Copy link
Contributor Author

sullis commented Feb 23, 2024

when I run this command:

mvn -B clean compile

the output includes the download of each individual jar file:

[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/ow2/asm/asm/9.3/asm-9.3.jar (122 kB at 399 kB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/ow2/asm/asm-commons/9.2/asm-commons-9.2.jar

When I run the same command with the "ntp" option

mvn -B -ntp clean compile

the output does not include any of the "download" messages

@sullis
Copy link
Contributor Author

sullis commented Feb 23, 2024

the Netty project uses "-B" and "-ntp" in the GitHub Actions build

image

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logs printed while building the project are reduced by about half (4000+ to 2000+). I'm good with the change, thanks!

@Jackie-Jiang Jackie-Jiang merged commit 3d7bc6f into apache:master Feb 23, 2024
20 of 21 checks passed
@sullis sullis deleted the sean/maven-no-transfer-progress branch February 23, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants