Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untrack the segment out of TTL #12449

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Feb 20, 2024

If not remove the segment from _untrackedSegment, the takeSnapshot() method would fail to take the snapshot for this removed segment, as its directory is already deleted from disk.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8c395ff) 61.73% compared to head (6cd9510) 61.76%.

Files Patch % Lines
...cal/upsert/BasePartitionUpsertMetadataManager.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12449      +/-   ##
============================================
+ Coverage     61.73%   61.76%   +0.02%     
  Complexity      207      207              
============================================
  Files          2436     2436              
  Lines        133173   133175       +2     
  Branches      20631    20632       +1     
============================================
+ Hits          82220    82258      +38     
+ Misses        44907    44868      -39     
- Partials       6046     6049       +3     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.72% <60.00%> (+0.03%) ⬆️
java-21 61.61% <60.00%> (-0.01%) ⬇️
skip-bytebuffers-false 61.74% <60.00%> (+0.04%) ⬆️
skip-bytebuffers-true 61.59% <60.00%> (+<0.01%) ⬆️
temurin 61.76% <60.00%> (+0.02%) ⬆️
unittests 61.76% <60.00%> (+0.02%) ⬆️
unittests1 46.88% <0.00%> (+0.02%) ⬆️
unittests2 27.74% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@klsince klsince merged commit 16e97c5 into apache:master Feb 21, 2024
19 checks passed
@klsince klsince deleted the untrack_segment_outside_metadata_ttl branch February 21, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants