Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share the same table config object #12463

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Feb 22, 2024

Some method like TableUpsertMetadataManagerFactory.create may set new config values into tableconfig, so share the same tableconfig object as owned by tableDataManager.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e161b78) 61.73% compared to head (00f22ef) 61.75%.
Report is 2 commits behind head on master.

Files Patch % Lines
...ata/manager/realtime/RealtimeTableDataManager.java 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12463      +/-   ##
============================================
+ Coverage     61.73%   61.75%   +0.01%     
  Complexity      207      207              
============================================
  Files          2436     2436              
  Lines        133185   133183       -2     
  Branches      20629    20628       -1     
============================================
+ Hits          82227    82249      +22     
+ Misses        44911    44890      -21     
+ Partials       6047     6044       -3     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.69% <40.00%> (+<0.01%) ⬆️
java-21 61.62% <40.00%> (+<0.01%) ⬆️
skip-bytebuffers-false 61.73% <40.00%> (+0.01%) ⬆️
skip-bytebuffers-true 61.59% <40.00%> (-0.01%) ⬇️
temurin 61.75% <40.00%> (+0.01%) ⬆️
unittests 61.75% <40.00%> (+0.01%) ⬆️
unittests1 46.87% <40.00%> (+<0.01%) ⬆️
unittests2 27.75% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klsince klsince merged commit 6b0cfeb into apache:master Feb 22, 2024
19 checks passed
@klsince klsince deleted the share_same_tablecfg_obj branch February 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants