enable Netty leak detection #12483
Merged
enable Netty leak detection #12483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12483 +/- ##
============================================
+ Coverage 61.72% 61.74% +0.01%
- Complexity 201 207 +6
============================================
Files 2436 2436
Lines 133219 133219
Branches 20635 20635
============================================
+ Hits 82232 82257 +25
+ Misses 44943 44900 -43
- Partials 6044 6062 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Feb 24, 2024
sullis
changed the title
|
ready to merge @xiangfu0 |
There was a problem hiding this comment.
Thanks for the contribution! Can you please reformat the changes to follow Pinot Style?
sullis
force-pushed
the
sean/testng-netty-leak-detection
branch
from
61e0185
to
8d9dace
Compare
Done ✅ |
Jackie-Jiang
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
detect Netty leaks using Netty's paranoid leak detector
Modifications:
Result:
TestNG listener verifies that there are zero Netty leaks