Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Netty unit test #12486

Merged
merged 2 commits into from
Feb 24, 2024
Merged

add Netty unit test #12486

merged 2 commits into from
Feb 24, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Feb 24, 2024

add Netty unit test

@sullis sullis force-pushed the sean/netty-unit-test branch 2 times, most recently from 40fc064 to 1560a20 Compare February 24, 2024 02:25
@sullis sullis changed the title testing: add Netty unit test add Netty unit test Feb 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.74%. Comparing base (59551e4) to head (1560a20).

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12486      +/-   ##
============================================
- Coverage     61.75%   61.74%   -0.01%     
  Complexity      207      207              
============================================
  Files          2436     2436              
  Lines        133233   133233              
  Branches      20636    20636              
============================================
- Hits          82274    82268       -6     
- Misses        44911    44914       +3     
- Partials       6048     6051       +3     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (ø)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 61.68% <ø> (-0.02%) ⬇️
java-21 61.63% <ø> (+<0.01%) ⬆️
skip-bytebuffers-false 61.73% <ø> (-0.02%) ⬇️
skip-bytebuffers-true 61.59% <ø> (+33.87%) ⬆️
temurin 61.74% <ø> (-0.01%) ⬇️
unittests 61.74% <ø> (-0.01%) ⬇️
unittests1 46.87% <ø> (-0.02%) ⬇️
unittests2 27.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang
Copy link
Contributor

Thanks for the contribution! Can you please reformat the changes to follow Pinot Style?

@sullis
Copy link
Contributor Author

sullis commented Feb 24, 2024

Thanks for the contribution! Can you please reformat the changes to follow Pinot Style?

Done ✅

@Jackie-Jiang Jackie-Jiang merged commit cd41d70 into apache:master Feb 24, 2024
19 checks passed
@sullis sullis deleted the sean/netty-unit-test branch February 27, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants