Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the race condition in H3InclusionIndexFilterOperator #12487

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

Jackie-Jiang
Copy link
Contributor

Fix the race condition in H3InclusionIndexFilterOperator where the cached value is modified:

  • Change H3Utils to directly return potentially covered cells excluding the fully covered cells
  • Optimize H3Utils accordingly

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 26.00000% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 61.75%. Comparing base (59551e4) to head (4dd35cb).

Files Patch % Lines
.../org/apache/pinot/segment/local/utils/H3Utils.java 0.00% 35 Missing ⚠️
...perator/filter/H3InclusionIndexFilterOperator.java 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #12487   +/-   ##
=========================================
  Coverage     61.75%   61.75%           
  Complexity      207      207           
=========================================
  Files          2436     2436           
  Lines        133233   133236    +3     
  Branches      20636    20639    +3     
=========================================
+ Hits          82274    82281    +7     
+ Misses        44911    44905    -6     
- Partials       6048     6050    +2     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.70% <26.00%> (-0.01%) ⬇️
java-21 61.63% <26.00%> (+<0.01%) ⬆️
skip-bytebuffers-false 61.72% <26.00%> (-0.02%) ⬇️
skip-bytebuffers-true 61.60% <26.00%> (+33.88%) ⬆️
temurin 61.75% <26.00%> (+<0.01%) ⬆️
unittests 61.75% <26.00%> (+<0.01%) ⬆️
unittests1 46.89% <26.00%> (+<0.01%) ⬆️
unittests2 27.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit fb1b79d into apache:master Feb 24, 2024
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_h3_inclusion branch February 24, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants