Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParquetAvro int96 parity with parquetNative reader #12496

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

swaminathanmanish
Copy link
Contributor

Whats in the PR:
Keeping int96 interpretation the same for parquetAvro and parquetNative readers.

Why its needed:
This PR allowed int96 to be read by parquetAvro reader. However it is read as byte array (12 bytes). The parquetNative extractor translates int96 to a long. This PR does the same translation when parquetAvro reader is used.

Test:
parquetNative and ParquetAvro output values should match for int96 column.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 61.78%. Comparing base (59551e4) to head (15e17e1).
Report is 11 commits behind head on master.

Files Patch % Lines
...nputformat/parquet/ParquetAvroRecordExtractor.java 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12496      +/-   ##
============================================
+ Coverage     61.75%   61.78%   +0.03%     
  Complexity      207      207              
============================================
  Files          2436     2437       +1     
  Lines        133233   133255      +22     
  Branches      20636    20644       +8     
============================================
+ Hits          82274    82328      +54     
+ Misses        44911    44874      -37     
- Partials       6048     6053       +5     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.70% <92.00%> (-0.01%) ⬇️
java-21 61.66% <92.00%> (+0.04%) ⬆️
skip-bytebuffers-false 61.75% <92.00%> (+0.01%) ⬆️
skip-bytebuffers-true 61.60% <92.00%> (+33.88%) ⬆️
temurin 61.78% <92.00%> (+0.03%) ⬆️
unittests 61.77% <92.00%> (+0.03%) ⬆️
unittests1 46.90% <0.00%> (+0.01%) ⬆️
unittests2 27.75% <92.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swaminathanmanish swaminathanmanish changed the title (WIP YET ...) ParquetAvro int96 parity with parquetNative reader ParquetAvro int96 parity with parquetNative reader Feb 26, 2024
@swaminathanmanish swaminathanmanish marked this pull request as ready for review February 26, 2024 17:59
Copy link
Contributor

@snleee snleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snleee snleee merged commit 3267a74 into apache:master Feb 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants