Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GuavaRateLimiter acquire method #12500

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Feb 26, 2024

No description provided.

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sullis sullis force-pushed the PinotRealtimeSource-GuavaRateLimiter-acquire branch from c423f2b to 383b411 Compare February 26, 2024 23:20
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.73%. Comparing base (59551e4) to head (383b411).
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12500      +/-   ##
============================================
- Coverage     61.75%   61.73%   -0.02%     
  Complexity      207      207              
============================================
  Files          2436     2436              
  Lines        133233   133242       +9     
  Branches      20636    20647      +11     
============================================
- Hits          82274    82255      -19     
- Misses        44911    44935      +24     
- Partials       6048     6052       +4     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (ø)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 61.69% <ø> (-0.02%) ⬇️
java-21 61.60% <ø> (-0.03%) ⬇️
skip-bytebuffers-false 61.72% <ø> (-0.03%) ⬇️
skip-bytebuffers-true 61.58% <ø> (+33.85%) ⬆️
temurin 61.73% <ø> (-0.02%) ⬇️
unittests 61.72% <ø> (-0.02%) ⬇️
unittests1 46.86% <ø> (-0.03%) ⬇️
unittests2 27.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sullis
Copy link
Contributor Author

sullis commented Feb 27, 2024

ready to merge

@Jackie-Jiang Jackie-Jiang merged commit 19e1ab7 into apache:master Feb 27, 2024
19 checks passed
@sullis sullis deleted the PinotRealtimeSource-GuavaRateLimiter-acquire branch February 27, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants