Metric for upsert tables count #12505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
approved these changes
Feb 27, 2024
| if (tableConfig == null) { | ||
| LOGGER.warn("Found null table config for table: {}. Resetting table config metrics.", tableNameWithType); | ||
| _controllerMetrics.setValueOfTableGauge(tableNameWithType, ControllerGauge.REPLICATION_FROM_CONFIG, 0); | ||
| return; | ||
| } | ||
| if (tableConfig.isUpsertEnabled()) { |
There was a problem hiding this comment.
Shall we also move _offlineTableCount and _realTimeTableCount metric update here?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12505 +/- ##
============================================
- Coverage 61.75% 61.72% -0.03%
Complexity 207 207
============================================
Files 2436 2449 +13
Lines 133233 133507 +274
Branches 20636 20687 +51
============================================
+ Hits 82274 82409 +135
- Misses 44911 45015 +104
- Partials 6048 6083 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a metric to get the count of tables which have upsert enabled.