Added /uptime and /start-time for all components. Addressed comments and fixed tests from pull request 12389.

[suyashpatel98]

Addresses #12298. Added /uptime and /start-time for all components. Addressed comments and verified tests pass from pull request 12389 (Closed that request because the history of that PR got messy). Tested /uptime and /start-time endpoints on my local machine. See the attached images

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 16.66667% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 61.69%. Comparing base (59551e4) to head (2ea97f3).
Report is 43 commits behind head on master.

Files	Patch %	Lines
...t/broker/api/resources/PinotBrokerHealthCheck.java	0.00%	7 Missing ⚠️
...ller/api/resources/PinotControllerHealthCheck.java	0.00%	7 Missing ⚠️
...inot/minion/api/resources/HealthCheckResource.java	0.00%	7 Missing ⚠️
...inot/server/api/resources/HealthCheckResource.java	0.00%	7 Missing ⚠️
...apache/pinot/minion/MinionAdminApiApplication.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #12512      +/-   ##
============================================
- Coverage     61.75%   61.69%   -0.06%     
  Complexity      207      207              
============================================
  Files          2436     2449      +13     
  Lines        133233   133539     +306     
  Branches      20636    20690      +54     
============================================
+ Hits          82274    82388     +114     
- Misses        44911    45072     +161     
- Partials       6048     6079      +31     

Flag	Coverage Δ
custom-integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration	<0.01% <0.00%> (-0.01%)	⬇️
integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration2	0.00% <0.00%> (ø)
java-11	61.64% <16.66%> (-0.07%)	⬇️
java-21	61.57% <16.66%> (-0.06%)	⬇️
skip-bytebuffers-false	61.67% <16.66%> (-0.08%)	⬇️
skip-bytebuffers-true	61.53% <16.66%> (+33.80%)	⬆️
temurin	61.69% <16.66%> (-0.06%)	⬇️
unittests	61.69% <16.66%> (-0.06%)	⬇️
unittests1	46.85% <ø> (-0.04%)	⬇️
unittests2	27.69% <16.66%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Jackie-Jiang]

Do we want uptime in seconds, or in a more human readable format?

[suyashpatel98]

Do we want uptime in seconds, or in a more human readable format?

@Jackie-Jiang Xiang in the old PR (here) was inclined towards returning just a number. I am okay either way - don't have a strong preference

[suyashpatel98]

ForwardIndexHandlerTest.testAddOtherIndexForForwardIndexDisabledColumn() is a flaky test. There is an existing open issue - #11928

[xiangfu0]

as inclined towards returning just a number. I am okay either way - don't have a strong preference

I prefer epoch value, UI side can decide how to show it.

[xiangfu0]

Thanks for adding this feature @suyashpatel98 !