Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egalpin/skip indexes minor changes #12514

Merged

Conversation

egalpin
Copy link
Member

@egalpin egalpin commented Feb 28, 2024

Relates to #12414. Minor naming changes based on PR comments.

cc/ @Jackie-Jiang @gortiz

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 61.73%. Comparing base (59551e4) to head (9935222).
Report is 34 commits behind head on master.

Files Patch % Lines
...pinot/core/query/request/context/QueryContext.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12514      +/-   ##
============================================
- Coverage     61.75%   61.73%   -0.02%     
  Complexity      207      207              
============================================
  Files          2436     2450      +14     
  Lines        133233   133552     +319     
  Branches      20636    20692      +56     
============================================
+ Hits          82274    82451     +177     
- Misses        44911    44998      +87     
- Partials       6048     6103      +55     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.66% <84.61%> (-0.05%) ⬇️
java-21 61.61% <84.61%> (-0.01%) ⬇️
skip-bytebuffers-false 61.72% <84.61%> (-0.03%) ⬇️
skip-bytebuffers-true 61.56% <84.61%> (+33.83%) ⬆️
temurin 61.73% <84.61%> (-0.02%) ⬇️
unittests 61.73% <84.61%> (-0.02%) ⬇️
unittests1 46.88% <84.61%> (-0.01%) ⬇️
unittests2 27.70% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Jackie-Jiang
Copy link
Contributor

Can you please take a look at the test failures?

@egalpin
Copy link
Member Author

egalpin commented Feb 29, 2024

@Jackie-Jiang all set, I believe the first tests that failed were due to noisy remote test environment. I tried to make a change to account for the failures in 733d179, which was simply misguided.

@Jackie-Jiang Jackie-Jiang merged commit f51c34f into apache:master Mar 1, 2024
19 checks passed
@Jackie-Jiang
Copy link
Contributor

Thank you for addressing the comments! Can you help contribute this new query option to the pinot doc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants