-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Egalpin/skip indexes minor changes #12514
Egalpin/skip indexes minor changes #12514
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12514 +/- ##
============================================
- Coverage 61.75% 61.73% -0.02%
Complexity 207 207
============================================
Files 2436 2450 +14
Lines 133233 133552 +319
Branches 20636 20692 +56
============================================
+ Hits 82274 82451 +177
- Misses 44911 44998 +87
- Partials 6048 6103 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Can you please take a look at the test failures? |
This reverts commit 733d179.
@Jackie-Jiang all set, I believe the first tests that failed were due to noisy remote test environment. I tried to make a change to account for the failures in 733d179, which was simply misguided. |
Thank you for addressing the comments! Can you help contribute this new query option to the pinot doc? |
Relates to #12414. Minor naming changes based on PR comments.
cc/ @Jackie-Jiang @gortiz