Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor TlsUtils class #12515

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

zhtaoxiang
Copy link
Contributor

@zhtaoxiang zhtaoxiang commented Feb 28, 2024

refactor the TlsUtils class to move recently added renewable tls logic to a separate class to make it easy to read.

There is no logic change.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 54.31034% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 61.70%. Comparing base (59551e4) to head (757342f).
Report is 24 commits behind head on master.

Files Patch % Lines
...ache/pinot/common/utils/tls/RenewableTlsUtils.java 58.33% 31 Missing and 14 partials ⚠️
...va/org/apache/pinot/common/utils/tls/TlsUtils.java 0.00% 4 Missing ⚠️
...pache/pinot/common/utils/grpc/GrpcQueryClient.java 0.00% 1 Missing ⚠️
...e/pinot/common/utils/tls/JvmDefaultSslContext.java 0.00% 1 Missing ⚠️
...che/pinot/core/transport/grpc/GrpcQueryServer.java 0.00% 1 Missing ⚠️
...org/apache/pinot/core/util/ListenerConfigUtil.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12515      +/-   ##
============================================
- Coverage     61.75%   61.70%   -0.06%     
  Complexity      207      207              
============================================
  Files          2436     2450      +14     
  Lines        133233   133497     +264     
  Branches      20636    20682      +46     
============================================
+ Hits          82274    82370      +96     
- Misses        44911    45047     +136     
- Partials       6048     6080      +32     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.66% <54.31%> (-0.05%) ⬇️
java-21 61.55% <54.31%> (-0.07%) ⬇️
skip-bytebuffers-false 61.68% <54.31%> (-0.06%) ⬇️
skip-bytebuffers-true 61.53% <54.31%> (+33.80%) ⬆️
temurin 61.70% <54.31%> (-0.06%) ⬇️
unittests 61.69% <54.31%> (-0.06%) ⬇️
unittests1 46.85% <54.31%> (-0.04%) ⬇️
unittests2 27.68% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 self-requested a review February 29, 2024 00:23
@xiangfu0 xiangfu0 merged commit 53b3bfa into apache:master Feb 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants