Modify consumingSegmentsInfo endpoint to indicate how many servers failed #12523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12523 +/- ##
============================================
- Coverage 61.75% 61.46% -0.29%
+ Complexity 207 198 -9
============================================
Files 2436 2452 +16
Lines 133233 133848 +615
Branches 20636 20766 +130
============================================
- Hits 82274 82270 -4
- Misses 44911 45406 +495
- Partials 6048 6172 +124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Mar 5, 2024
| @@ -132,7 +133,8 @@ private Map<String, List<SegmentConsumerInfo>> getConsumingSegmentsInfoFromServe | |||
| if (failedParses != 0) { | |||
| LOGGER.warn("Failed to parse {} / {} segment size info responses from servers.", failedParses, serverUrls.size()); | |||
| } | |||
| return serverToConsumingSegmentInfoList; | |||
| return new ConsumingSegmentsInfoFromServersResponse( | |||
| serverToConsumingSegmentInfoList, serviceResponse._failedResponseCount); | |||
There was a problem hiding this comment.
Since we are gathering the servers not responded, should we also include un-parsable responses as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller endpoint /table/consumingSegmentsInfo may return partial information when servers timeout or there is a parsing error dealing with their response. These cases registered as a log, but there is no notice in the response to understand if it is complete or shows partial information, so it is easy to think that the current issue is that there are segments we are not actually consuming from.
This PR tries to improve the usability of the endpoint by adding the new field
serversFailingToRespondon /table/consumingSegmentsInfo that indicates the number of servers that have failed to answer