Logging a warn message instead of throwing exception for adhoc trigger #12546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
approved these changes
Mar 4, 2024
xiangfu0
reviewed
Mar 4, 2024
...controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12546 +/- ##
============================================
- Coverage 61.75% 61.71% -0.04%
Complexity 207 207
============================================
Files 2436 2451 +15
Lines 133233 133632 +399
Branches 20636 20689 +53
============================================
+ Hits 82274 82473 +199
- Misses 44911 45061 +150
- Partials 6048 6098 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
snleee
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats in the PR:
Logging a warn message when no task is submitted, instead of throwing an exception.
Why its needed:
The underlying task implementation need not generate a task for various reasons (eg: not re-ingesting same data). When there are no issues with the task trigger itself (eg: invalid inputs), we should not be throwing an exception which misleads users of this API into thinking theres an issue in the way, api is used. Also the logic in createTask does allow for empty task from individual taskType. We can stick to a warn message when none of the taskTypes generates a task. We do propagate the exception when there are invalid inputs or underlying task implementation throws an exception.
if (pinotTaskConfigs.isEmpty()) {
LOGGER.warn("No ad-hoc task generated for task type: {}", taskType);
continue;
}