bugfix: fix shared buffer in v4 raw forward index writer #12587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itschrispeck
commented
Mar 7, 2024
...l/src/test/java/org/apache/pinot/segment/local/segment/index/creator/VarByteChunkV4Test.java
Show resolved
Hide resolved
itschrispeck
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12587 +/- ##
============================================
+ Coverage 61.75% 61.78% +0.03%
- Complexity 207 211 +4
============================================
Files 2436 2451 +15
Lines 133233 133730 +497
Branches 20636 20704 +68
============================================
+ Hits 82274 82629 +355
- Misses 44911 44984 +73
- Partials 6048 6117 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
reviewed
Mar 7, 2024
| @@ -94,7 +94,7 @@ public class VarByteChunkForwardIndexWriterV4 implements VarByteChunkWriter { | |||
|
|
|||
| public VarByteChunkForwardIndexWriterV4(File file, ChunkCompressionType compressionType, int chunkSize) | |||
| throws IOException { | |||
| _dataBuffer = new File(file.getName() + DATA_BUFFER_SUFFIX); | |||
| _dataBuffer = new File(file.getParentFile(), file.getName() + DATA_BUFFER_SUFFIX); | |||
There was a problem hiding this comment.
We might also want to check its existence, and delete it if exists
...l/src/test/java/org/apache/pinot/segment/local/segment/index/creator/VarByteChunkV4Test.java
Show resolved
Hide resolved
chenboat
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanning column data for columns using
rawIndexWriterVersion=4caused intermittent buffer position exceptions and decompression exceptions. When investigating this I noticed chunks from one partition were saved in the segment for another partition. This was caused by using a buffer constructed with a relative path:Tests are updated to cover concurrent writing (multiple writers, sequential per writer), and also adds tests for MV functionality
tags:
bugfix