Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for QueryServer #12599

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Mar 8, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 61.78%. Comparing base (59551e4) to head (e461c09).
Report is 92 commits behind head on master.

Files Patch % Lines
...a/org/apache/pinot/core/transport/QueryServer.java 42.85% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12599      +/-   ##
============================================
+ Coverage     61.75%   61.78%   +0.03%     
- Complexity      207      211       +4     
============================================
  Files          2436     2451      +15     
  Lines        133233   133846     +613     
  Branches      20636    20750     +114     
============================================
+ Hits          82274    82695     +421     
- Misses        44911    45046     +135     
- Partials       6048     6105      +57     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.71% <42.85%> (+<0.01%) ⬆️
java-21 61.66% <42.85%> (+0.04%) ⬆️
skip-bytebuffers-false 61.77% <42.85%> (+0.02%) ⬆️
skip-bytebuffers-true 61.61% <42.85%> (+33.88%) ⬆️
temurin 61.78% <42.85%> (+0.03%) ⬆️
unittests 61.77% <42.85%> (+0.03%) ⬆️
unittests1 46.93% <42.85%> (+0.03%) ⬆️
unittests2 27.70% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sullis
Copy link
Contributor Author

sullis commented Mar 8, 2024

ready for review

@Jackie-Jiang Jackie-Jiang merged commit bca1e82 into apache:master Mar 8, 2024
19 checks passed
@sullis sullis deleted the sean/add-QueryServerTest branch March 8, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants