-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12435: fix for quick start Cluster Manager issue #12610
Conversation
hmm, it seems I definitely introduced this, but can you tell which part of the home page is making this happen? It seems like the UI itself is unaffected, but there's just stray, bad requests? |
I wasn't able to track from where the requests were getting originated. Console log was mentioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's unfortunately no better testing here. so as long as you click around and nothing is actively broken, this is fine with me
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12610 +/- ##
============================================
+ Coverage 61.75% 61.81% +0.06%
+ Complexity 207 198 -9
============================================
Files 2436 2450 +14
Lines 133233 133748 +515
Branches 20636 20743 +107
============================================
+ Hits 82274 82677 +403
- Misses 44911 44965 +54
- Partials 6048 6106 +58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@abhioncbr This is a minor frontend bug. I can create a PR if required. The API was called before the |
@karthi07 I guess you just found the root cause! Yes please file a PR! |
@Jackie-Jiang created PR, let me know if additional details are required, this is my first PR for Pinot :) |
while working on my local build, I saw the
//LIVEINSTANCES
issue and found the reported bug related to it.I think, this issue got introduced with the PR, Just putting a simple fix for the issue.
cc: @jadami10, @xiangfu0