Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12435: fix for quick start Cluster Manager issue #12610

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

abhioncbr
Copy link
Contributor

while working on my local build, I saw the //LIVEINSTANCES issue and found the reported bug related to it.

I think, this issue got introduced with the PR, Just putting a simple fix for the issue.

Screenshot 2024-03-08 at 3 07 30 PM

cc: @jadami10, @xiangfu0

@Jackie-Jiang Jackie-Jiang added ui UI related issue bugfix labels Mar 8, 2024
@jadami10
Copy link
Contributor

jadami10 commented Mar 8, 2024

hmm, it seems I definitely introduced this, but can you tell which part of the home page is making this happen? It seems like the UI itself is unaffected, but there's just stray, bad requests?

@abhioncbr
Copy link
Contributor Author

abhioncbr commented Mar 8, 2024

hmm, it seems I definitely introduced this, but can you tell which part of the home page is making this happen? It seems like the UI itself is unaffected, but there's just stray, bad requests?

I wasn't able to track from where the requests were getting originated. Console log was mentioning main.js 79161, but some of the requests for the LIVEINSTANCES was coming without clusterName and hence I thought to check whether we have the value for it or not.

Copy link
Contributor

@jadami10 jadami10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's unfortunately no better testing here. so as long as you click around and nothing is actively broken, this is fine with me

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.81%. Comparing base (59551e4) to head (2253dd1).
Report is 100 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12610      +/-   ##
============================================
+ Coverage     61.75%   61.81%   +0.06%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2450      +14     
  Lines        133233   133748     +515     
  Branches      20636    20743     +107     
============================================
+ Hits          82274    82677     +403     
- Misses        44911    44965      +54     
- Partials       6048     6106      +58     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 61.73% <ø> (+0.02%) ⬆️
java-21 61.69% <ø> (+0.07%) ⬆️
skip-bytebuffers-false 61.77% <ø> (+0.02%) ⬆️
skip-bytebuffers-true 61.65% <ø> (+33.92%) ⬆️
temurin 61.81% <ø> (+0.06%) ⬆️
unittests 61.81% <ø> (+0.06%) ⬆️
unittests1 46.92% <ø> (+0.03%) ⬆️
unittests2 27.71% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit c2d7846 into apache:master Mar 8, 2024
18 of 19 checks passed
@abhioncbr abhioncbr deleted the 12435-fix branch March 8, 2024 22:31
@karthi07
Copy link
Contributor

karthi07 commented Mar 10, 2024

@abhioncbr This is a minor frontend bug. I can create a PR if required.

The API was called before the clusterName useState was loaded.

image

@Jackie-Jiang
Copy link
Contributor

@karthi07 I guess you just found the root cause! Yes please file a PR!

@karthi07
Copy link
Contributor

@Jackie-Jiang created PR, let me know if additional details are required, this is my first PR for Pinot :)

#12632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix ui UI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants