Fix the ConcurrentModificationException for And/Or DocIdSet #12611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12611 +/- ##
=============================================
- Coverage 61.75% 0.00% -61.75%
+ Complexity 207 6 -201
=============================================
Files 2436 2375 -61
Lines 133233 130119 -3114
Branches 20636 20196 -440
=============================================
- Hits 82274 6 -82268
- Misses 44911 130113 +85202
+ Partials 6048 0 -6048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Mar 10, 2024
|
@Jackie-Jiang : we are seeing this in our internal 1.1 release cut build as well. We didn't add this to that release? cc: @vvivekiyer |
|
No, seems it is not included.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12368
When a query is early terminated, some segments might still be executing while the combine operator is collecting execution stats. This can cause
ConcurrentModificationExceptionforAndDocIdSetandOrDocIdSetsince both methods are accessing the same List, and one is modifying it (introduced in #11200).This PR fixed issue by keeping the scan based DocIdSets in a separate list