Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pinot-parquet NoClassFound issue #12615

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Mar 10, 2024

ParquetUtils.hasAvroSchemaInFileMetadata() may throw exception when using it.
So still need to put hadoop-mapreduce-client-core as dependency.

java.lang.NoClassDefFoundError: org/apache/hadoop/mapreduce/lib/input/FileInputFormat
	at java.base/java.lang.ClassLoader.defineClass1(Native Method) ~[?:?]
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017) ~[?:?]
	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174) ~[?:?]
	at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:800) ~[?:?]
	at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:698) ~[?:?]
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:621) ~[?:?]
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:579) ~[?:?]
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) ~[?:?]
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522) ~[?:?]
	at org.apache.parquet.HadoopReadOptions$Builder.<init>(HadoopReadOptions.java:112) ~[parquet-hadoop-1.13.1.jar:1.13.1]
	at org.apache.parquet.HadoopReadOptions.builder(HadoopReadOptions.java:89) ~[parquet-hadoop-1.13.1.jar:1.13.1]
	at org.apache.parquet.hadoop.ParquetFileReader.readFooter(ParquetFileReader.java:523) ~[parquet-hadoop-1.13.1.jar:1.13.1]
	at org.apache.parquet.hadoop.ParquetFileReader.readFooter(ParquetFileReader.java:478) ~[parquet-hadoop-1.13.1.jar:1.13.1]
	at org.apache.pinot.plugin.inputformat.parquet.ParquetUtils.hasAvroSchemaInFileMetadata(ParquetUtils.java:81) ~[pinot-parquet-1.2.0-20240309.090137-47.jar:1.2.0-SNAPSHOT-b2689bcd8034fe17a627bcec1d46c850c5290104]
	at org.apache.pinot.plugin.inputformat.parquet.ParquetRecordReader.init(ParquetRecordReader.java:54) ~[pinot-parquet-1.2.0-20240309.090137-47.jar:1.2.0-SNAPSHOT-b2689bcd8034fe17a627bcec1d46c850c5290104]
	at org.apache.pinot.spi.data.readers.RecordReaderFactory.getRecordReaderByClass(RecordReaderFactory.java:148) ~[pinot-spi-1.2.0-20240309.090137-49.jar:1.2.0-SNAPSHOT-b2689bcd8034fe17a627bcec1d46c850c5290104]
	at org.apache.pinot.spi.data.readers.RecordReaderFactory.getRecordReader(RecordReaderFactory.java:171) ~[pinot-spi-1.2.0-20240309.090137-49.jar:1.2.0-SNAPSHOT-b2689bcd8034fe17a627bcec1d46c850c5290104]
	at org.apache.pinot.spi.data.readers.RecordReaderFactory.getRecordReader(RecordReaderFactory.java:158) ~[pinot-spi-1.2.0-20240309.090137-49.jar:1.2.0-SNAPSHOT-b2689bcd8034fe17a627bcec1d46c850c5290104]

@xiangfu0 xiangfu0 force-pushed the fix-pinot-parquet-dependency branch from 38639ba to 8dfacc6 Compare March 10, 2024 14:35
@xiangfu0 xiangfu0 added dependencies Pull requests that update a dependency file bugfix labels Mar 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.76%. Comparing base (59551e4) to head (8dfacc6).
Report is 103 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12615      +/-   ##
============================================
+ Coverage     61.75%   61.76%   +0.01%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2452      +16     
  Lines        133233   133791     +558     
  Branches      20636    20749     +113     
============================================
+ Hits          82274    82639     +365     
- Misses        44911    45050     +139     
- Partials       6048     6102      +54     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 61.72% <ø> (+0.01%) ⬆️
java-21 61.65% <ø> (+0.02%) ⬆️
skip-bytebuffers-false 61.75% <ø> (+<0.01%) ⬆️
skip-bytebuffers-true 61.62% <ø> (+33.89%) ⬆️
temurin 61.76% <ø> (+0.01%) ⬆️
unittests 61.76% <ø> (+0.01%) ⬆️
unittests1 46.89% <ø> (+<0.01%) ⬆️
unittests2 27.68% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 merged commit 1ae85e1 into apache:master Mar 11, 2024
21 checks passed
@xiangfu0 xiangfu0 deleted the fix-pinot-parquet-dependency branch March 11, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants