Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust the llc partition consuming metric reporting logic #12627

Conversation

zhtaoxiang
Copy link
Contributor

@zhtaoxiang zhtaoxiang commented Mar 11, 2024

Adjust the llc partition consuming metric reporting logic to make it a little bit more consistent.

Currently, the llc partition consuming metric is reported as 1 when

  1. the kafka consumer reads some messages, or
  2. when the kafka consumer has been idle for a predefined time.

The second condition is confusing because

  1. why would we report 0 for llc partition consuming metric initially and then change it to 1 just because of some time elapses?
  2. This also causes bugs if we rely on this metric to create alerts

To make the report logic to be consistent, we now report llc partition consuming metric as 1 as long as kafka consumer is trying to consume messages

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.76%. Comparing base (59551e4) to head (c096685).
Report is 107 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12627      +/-   ##
============================================
+ Coverage     61.75%   61.76%   +0.01%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2453      +17     
  Lines        133233   133823     +590     
  Branches      20636    20753     +117     
============================================
+ Hits          82274    82660     +386     
- Misses        44911    45049     +138     
- Partials       6048     6114      +66     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.73% <100.00%> (+0.02%) ⬆️
java-21 61.65% <100.00%> (+0.02%) ⬆️
skip-bytebuffers-false 61.75% <100.00%> (+<0.01%) ⬆️
skip-bytebuffers-true 61.63% <100.00%> (+33.90%) ⬆️
temurin 61.76% <100.00%> (+0.01%) ⬆️
unittests 61.76% <100.00%> (+0.01%) ⬆️
unittests1 46.91% <100.00%> (+0.02%) ⬆️
unittests2 27.67% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 2886e67 into apache:master Mar 12, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants