Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for JsonAsyncHttpPinotClientTransport #12633

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Mar 12, 2024

No description provided.

@sullis sullis force-pushed the sean/add-JsonAsyncHttpPinotClientTransportTest branch from 7a91642 to 492fb45 Compare March 12, 2024 16:31
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.70%. Comparing base (59551e4) to head (492fb45).
Report is 118 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12633       +/-   ##
=============================================
- Coverage     61.75%   27.70%   -34.05%     
+ Complexity      207      198        -9     
=============================================
  Files          2436     2453       +17     
  Lines        133233   133831      +598     
  Branches      20636    20754      +118     
=============================================
- Hits          82274    37079    -45195     
- Misses        44911    93921    +49010     
+ Partials       6048     2831     -3217     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 ?
java-11 27.70% <ø> (-34.01%) ⬇️
java-21 27.69% <ø> (-33.94%) ⬇️
skip-bytebuffers-false 27.70% <ø> (-34.05%) ⬇️
skip-bytebuffers-true 27.68% <ø> (-0.04%) ⬇️
temurin 27.70% <ø> (-34.05%) ⬇️
unittests 27.70% <ø> (-34.05%) ⬇️
unittests1 ?
unittests2 27.70% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sullis
Copy link
Contributor Author

sullis commented Mar 12, 2024

ready for review

@Jackie-Jiang Jackie-Jiang merged commit 93e1a8f into apache:master Mar 12, 2024
19 checks passed
@sullis sullis deleted the sean/add-JsonAsyncHttpPinotClientTransportTest branch March 13, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants