missed to delete the temp dir #12637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12637 +/- ##
============================================
+ Coverage 61.75% 61.81% +0.05%
+ Complexity 207 198 -9
============================================
Files 2436 2453 +17
Lines 133233 133864 +631
Branches 20636 20764 +128
============================================
+ Hits 82274 82742 +468
- Misses 44911 45012 +101
- Partials 6048 6110 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
klsince
commented
Mar 12, 2024
| @@ -346,7 +346,7 @@ protected void stopServer() { | |||
| for (BaseServerStarter serverStarter : _serverStarters) { | |||
| serverStarter.stop(); | |||
| } | |||
| FileUtils.deleteQuietly(new File(_baseInstanceDataDir + File.separator + "PinotServer")); | |||
| FileUtils.deleteQuietly(new File(_baseInstanceDataDir)); | |||
There was a problem hiding this comment.
otherwise, we'll see a lot of <tmpDir>/<timestamp> folders left in system temp dir
Jackie-Jiang
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missed to delete the temp dir after finishing the tests. the other upsert test cases cleaned up the temp dir in tearDown()