Assign default value to newly added derived column upon reload #12648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is intended to handle the case where the derived column depends on upstream data which is not a column in the table schema
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12648 +/- ##
============================================
- Coverage 61.75% 61.34% -0.41%
+ Complexity 207 198 -9
============================================
Files 2436 2452 +16
Lines 133233 133847 +614
Branches 20636 20765 +129
============================================
- Hits 82274 82109 -165
- Misses 44911 45577 +666
- Partials 6048 6161 +113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| // TODO: Support creation of derived columns from forward index disabled columns | ||
| if (!_segmentWriter.hasIndexFor(argument, StandardIndexes.forward())) { | ||
| // replace the transform function with the default value for the derived column | ||
| String expression = _schema.getFieldSpecFor(column).getDefaultNullValueString(); |
There was a problem hiding this comment.
You can simply short circuit it by invoking createDefaultValueColumnV1Indices(column)
There was a problem hiding this comment.
Yes, much better. Thanks for pointing it out!
reverted the changes and did as you suggested.
This reverts commit 331983b.
…argument in schema
Jackie-Jiang
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended to handle the case where the derived column depends on upstream data which is not a column in the table schema. Currently it fails reloading the existing segments as existing segments don’t have this data available. With this PR the newly added derived column will be assigned the default null value in such cases so that user is able to query the column across all segments.