Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving deleteSegment call from POST to DELETE call #12663

Merged

Conversation

tibrewalpratik17
Copy link
Contributor

label:
bugfix

Moving deleteSegments call from POST api to DELETE api like other delete-segment based apis.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 61.38%. Comparing base (59551e4) to head (4d2a7cb).
Report is 150 commits behind head on master.

Files Patch % Lines
...ler/api/resources/PinotSegmentRestletResource.java 33.33% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12663      +/-   ##
============================================
- Coverage     61.75%   61.38%   -0.37%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2452      +16     
  Lines        133233   133877     +644     
  Branches      20636    20733      +97     
============================================
- Hits          82274    82177      -97     
- Misses        44911    45533     +622     
- Partials       6048     6167     +119     
Flag Coverage Δ
custom-integration1 ?
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.37% <33.33%> (-0.34%) ⬇️
java-21 27.72% <33.33%> (-33.90%) ⬇️
skip-bytebuffers-false 61.38% <33.33%> (-0.37%) ⬇️
skip-bytebuffers-true 0.00% <0.00%> (-27.73%) ⬇️
temurin 61.38% <33.33%> (-0.37%) ⬇️
unittests 61.37% <33.33%> (-0.37%) ⬇️
unittests1 46.27% <ø> (-0.62%) ⬇️
unittests2 27.73% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we integrate it into DELETE /segments/{tableName} and add an extra parameter for target segments? If segments are not provided, we delete all segments

@tibrewalpratik17
Copy link
Contributor Author

Shall we integrate it into DELETE /segments/{tableName} and add an extra parameter for target segments? If segments are not provided, we delete all segments

Sounds good to me! Updated accordingly!

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding a test in PinotSegmentRestletResourceTest for the new usage

Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
@tibrewalpratik17
Copy link
Contributor Author

Suggest adding a test in PinotSegmentRestletResourceTest for the new usage

Will do Jackie.

@Jackie-Jiang Jackie-Jiang merged commit 4551d4f into apache:master Mar 21, 2024
18 of 19 checks passed
@tibrewalpratik17 tibrewalpratik17 deleted the remove_delete_call_from_post_api branch May 16, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants