-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving deleteSegment call from POST to DELETE call #12663
Moving deleteSegment call from POST to DELETE call #12663
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12663 +/- ##
============================================
- Coverage 61.75% 61.38% -0.37%
+ Complexity 207 198 -9
============================================
Files 2436 2452 +16
Lines 133233 133877 +644
Branches 20636 20733 +97
============================================
- Hits 82274 82177 -97
- Misses 44911 45533 +622
- Partials 6048 6167 +119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we integrate it into DELETE /segments/{tableName}
and add an extra parameter for target segments? If segments are not provided, we delete all segments
Sounds good to me! Updated accordingly! |
...ler/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest adding a test in PinotSegmentRestletResourceTest
for the new usage
...ler/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
Outdated
Show resolved
Hide resolved
...ler/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
Show resolved
Hide resolved
...ler/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
Will do Jackie. |
b2c1e1e
to
68e0a0b
Compare
label:
bugfix
Moving
deleteSegments
call from POST api to DELETE api like other delete-segment based apis.