Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. Avoid passing null table name input to translation util #12726

Merged

Conversation

shounakmk219
Copy link
Collaborator

This PR fixes the bug introduced in #12417 which blocked /tasks/schedule API with no table name input

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 61.48%. Comparing base (59551e4) to head (e78b172).
Report is 174 commits behind head on master.

Files Patch % Lines
...roller/api/resources/PinotTaskRestletResource.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12726      +/-   ##
============================================
- Coverage     61.75%   61.48%   -0.28%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2460      +24     
  Lines        133233   134601    +1368     
  Branches      20636    20838     +202     
============================================
+ Hits          82274    82753     +479     
- Misses        44911    45664     +753     
- Partials       6048     6184     +136     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.47% <0.00%> (-0.24%) ⬇️
java-21 27.91% <0.00%> (-33.71%) ⬇️
skip-bytebuffers-false 61.48% <0.00%> (-0.27%) ⬇️
skip-bytebuffers-true 0.00% <0.00%> (-27.73%) ⬇️
temurin 61.48% <0.00%> (-0.28%) ⬇️
unittests 61.47% <0.00%> (-0.28%) ⬇️
unittests1 46.07% <ø> (-0.82%) ⬇️
unittests2 27.92% <0.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saurabhd336 saurabhd336 merged commit 0c61bb6 into apache:master Mar 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants