Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make task manager APIs database aware #12766

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

shounakmk219
Copy link
Collaborator

@shounakmk219 shounakmk219 commented Apr 1, 2024

Description

Make PinotTaskManager APIs database aware and deprecate the APIs which do not accept database as param in favour of database aware APIs

Deprecated APIs

  • PinotTaskManager.scheduleTasks()
  • PinotTaskManager.scheduleTask()

The deprecated APIs assume default database for their operations.

Newly added APIs

  • PinotTaskManager.scheduleTasksForDatabase(String database)
  • PinotTaskManager.scheduleTaskForDatabase(String taskType, String database)

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 34.91%. Comparing base (59551e4) to head (1e88ba2).
Report is 200 commits behind head on master.

Files Patch % Lines
...controller/helix/core/minion/PinotTaskManager.java 0.00% 4 Missing ⚠️
...roller/api/resources/PinotTaskRestletResource.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12766       +/-   ##
=============================================
- Coverage     61.75%   34.91%   -26.84%     
+ Complexity      207        6      -201     
=============================================
  Files          2436     2386       -50     
  Lines        133233   131098     -2135     
  Branches      20636    20269      -367     
=============================================
- Hits          82274    45777    -36497     
- Misses        44911    82031    +37120     
+ Partials       6048     3290     -2758     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 ?
integration2 0.00% <0.00%> (ø)
java-11 34.91% <0.00%> (-26.80%) ⬇️
java-21 0.00% <0.00%> (-61.63%) ⬇️
skip-bytebuffers-false 34.91% <0.00%> (-26.84%) ⬇️
skip-bytebuffers-true 0.00% <0.00%> (-27.73%) ⬇️
temurin 34.91% <0.00%> (-26.84%) ⬇️
unittests 46.67% <ø> (-15.08%) ⬇️
unittests1 46.67% <ø> (-0.22%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKcorps KKcorps merged commit 11d64d0 into apache:master Apr 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants