Keep get tables API with and without database #12804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12804 +/- ##
============================================
+ Coverage 61.75% 62.02% +0.27%
+ Complexity 207 198 -9
============================================
Files 2436 2462 +26
Lines 133233 134720 +1487
Branches 20636 20812 +176
============================================
+ Hits 82274 83560 +1286
- Misses 44911 45017 +106
- Partials 6048 6143 +95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
force-pushed
the
fix_get_tables
branch
from
8b58b77
to
9c1614f
Compare
zhtaoxiang
reviewed
Apr 5, 2024
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Outdated
Show resolved
Hide resolved
zhtaoxiang
reviewed
Apr 5, 2024
| return new ArrayList<>(rawTableNames); | ||
| return getAllResources().stream().filter( | ||
| resourceName -> TableNameBuilder.isTableResource(resourceName) && DatabaseUtils.isPartOfDatabase(resourceName, | ||
| databaseName)).map(TableNameBuilder::extractRawTableName).distinct().collect(Collectors.toList()); |
There was a problem hiding this comment.
nit: could you please help me understand why we need to call distinct()?
There was a problem hiding this comment.
E.g. myTable_OFFLINE and myTable_REALTIME should result in one raw table name myTable
Jackie-Jiang
force-pushed
the
fix_get_tables
branch
from
9c1614f
to
dd4097b
Compare
Jackie-Jiang
force-pushed
the
fix_get_tables
branch
from
dd4097b
to
9fa02d6
Compare
xiangfu0
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From cluster management purpose, we need APIs to read table names from all databases. Keep the original APIs the same (without filtering on database), and for database aware purpose, use the new APIs.