Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package org.apache.calcite to org.apache.pinot.calcite #12837

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Jackie-Jiang
Copy link
Contributor

Move the Pinot classes under package org.apache.calcite to org.apache.pinot.calcite to avoid confusion

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.08%. Comparing base (59551e4) to head (684deed).
Report is 243 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12837      +/-   ##
============================================
+ Coverage     61.75%   62.08%   +0.33%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2492      +56     
  Lines        133233   135951    +2718     
  Branches      20636    21036     +400     
============================================
+ Hits          82274    84404    +2130     
- Misses        44911    45308     +397     
- Partials       6048     6239     +191     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.01% <100.00%> (+0.30%) ⬆️
java-21 61.96% <100.00%> (+0.33%) ⬆️
skip-bytebuffers-false 62.06% <100.00%> (+0.32%) ⬆️
skip-bytebuffers-true 61.91% <100.00%> (+34.19%) ⬆️
temurin 62.08% <100.00%> (+0.33%) ⬆️
unittests 62.07% <100.00%> (+0.33%) ⬆️
unittests1 46.97% <100.00%> (+0.07%) ⬆️
unittests2 27.73% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 620c46a into apache:master Apr 8, 2024
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the move_planner_package branch April 8, 2024 23:53
@Jackie-Jiang Jackie-Jiang added the backward-incompat Referenced by PRs that introduce or fix backward compat issues label Apr 15, 2024
@Jackie-Jiang
Copy link
Contributor Author

This change is introducing backward incompatibility because we rely on class path during query plan ser/de, and PinotRelExchangeType is part of the ser/de.
We should fix the ser/de so that it doesn't serialize the class path for both efficiency and forward compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-incompat Referenced by PRs that introduce or fix backward compat issues cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants