handle absent segments so that catchup checker doesn't get stuck on them #12883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12883 +/- ##
============================================
+ Coverage 61.75% 62.13% +0.38%
+ Complexity 207 198 -9
============================================
Files 2436 2502 +66
Lines 133233 136547 +3314
Branches 20636 21137 +501
============================================
+ Hits 82274 84840 +2566
- Misses 44911 45423 +512
- Partials 6048 6284 +236
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Fix #12381 |
klsince
force-pushed
the
handle_absent_segments_catchup_checker
branch
from
b681ee1
to
7b5fa51
Compare
klsince
force-pushed
the
handle_absent_segments_catchup_checker
branch
from
7b5fa51
to
f1a9673
Compare
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java
Outdated
Show resolved
Hide resolved
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/pinot/server/starter/helix/FreshnessBasedConsumptionStatusChecker.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/pinot/server/starter/helix/IngestionBasedConsumptionStatusChecker.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/pinot/server/starter/helix/IngestionBasedConsumptionStatusChecker.java
Show resolved
Hide resolved
klsince
force-pushed
the
handle_absent_segments_catchup_checker
branch
from
e9065d4
to
e85130c
Compare
Jackie-Jiang
approved these changes
Apr 19, 2024
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java
Show resolved
Hide resolved
.../main/java/org/apache/pinot/server/starter/helix/IngestionBasedConsumptionStatusChecker.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/pinot/server/starter/helix/IngestionBasedConsumptionStatusChecker.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/pinot/server/starter/helix/IngestionBasedConsumptionStatusChecker.java
Show resolved
Hide resolved
…mmitted by other servers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle absent segments so that catchup checker doesn't get stuck on them. When server is catching up, the tables or segments might get dropped, if those segments are not skipped, the checker will block server from starting up.