Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some mis-positioned tests under pinot-core #12884

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

Jackie-Jiang
Copy link
Contributor

These tests are mis-positioned under pinot-core, which should be positioned under spi, common or segment-local

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.17%. Comparing base (59551e4) to head (38f6538).
Report is 272 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12884      +/-   ##
============================================
+ Coverage     61.75%   62.17%   +0.42%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2502      +66     
  Lines        133233   136415    +3182     
  Branches      20636    21106     +470     
============================================
+ Hits          82274    84813    +2539     
- Misses        44911    45322     +411     
- Partials       6048     6280     +232     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 62.11% <ø> (+0.40%) ⬆️
java-21 62.05% <ø> (+0.43%) ⬆️
skip-bytebuffers-false 62.15% <ø> (+0.40%) ⬆️
skip-bytebuffers-true 62.01% <ø> (+34.28%) ⬆️
temurin 62.17% <ø> (+0.42%) ⬆️
unittests 62.16% <ø> (+0.42%) ⬆️
unittests1 46.77% <ø> (-0.12%) ⬇️
unittests2 27.92% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 5a90974 into apache:master Apr 11, 2024
17 of 19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the move_mispositioned_tests branch April 11, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants