Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup HTTP components dependencies and upgrade Thrift #12905

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

Another try of #12899

  • Upgrade httpmime to match httpclient (from 4.5.13 to 4.5.14)
  • Upgrade libthrift from 0.15.0 to 0.20.0
  • Introduce httpclient5 (5.3.1) and httpcore5 (5.2.4)

@Jackie-Jiang Jackie-Jiang added dependencies Pull requests that update a dependency file cleanup labels Apr 11, 2024
@Jackie-Jiang Jackie-Jiang force-pushed the cleanup_httpcomponents_dependencies branch from d680c1a to 2245e7e Compare April 11, 2024 20:00
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.18%. Comparing base (59551e4) to head (2245e7e).
Report is 287 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12905      +/-   ##
============================================
+ Coverage     61.75%   62.18%   +0.42%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2502      +66     
  Lines        133233   136416    +3183     
  Branches      20636    21106     +470     
============================================
+ Hits          82274    84826    +2552     
- Misses        44911    45306     +395     
- Partials       6048     6284     +236     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.11% <100.00%> (+0.40%) ⬆️
java-21 62.06% <100.00%> (+0.43%) ⬆️
skip-bytebuffers-false 62.15% <100.00%> (+0.40%) ⬆️
skip-bytebuffers-true 62.03% <100.00%> (+34.30%) ⬆️
temurin 62.18% <100.00%> (+0.42%) ⬆️
unittests 62.17% <100.00%> (+0.43%) ⬆️
unittests1 46.77% <ø> (-0.12%) ⬇️
unittests2 27.93% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 1f17c46 into apache:master Apr 11, 2024
21 checks passed
@Jackie-Jiang Jackie-Jiang deleted the cleanup_httpcomponents_dependencies branch April 11, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants