Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate bad server configs during broker startup phase #12931

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

lnbest0707-uber
Copy link
Contributor

@lnbest0707-uber lnbest0707-uber commented Apr 15, 2024

tags: bugfix

Fix issues mentioned in #12732

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.21%. Comparing base (59551e4) to head (5a9a249).
Report is 301 commits behind head on master.

Files Patch % Lines
...che/pinot/broker/routing/BrokerRoutingManager.java 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12931      +/-   ##
============================================
+ Coverage     61.75%   62.21%   +0.45%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2503      +67     
  Lines        133233   136500    +3267     
  Branches      20636    21117     +481     
============================================
+ Hits          82274    84918    +2644     
- Misses        44911    45307     +396     
- Partials       6048     6275     +227     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.17% <60.00%> (+0.46%) ⬆️
java-21 62.09% <60.00%> (+0.47%) ⬆️
skip-bytebuffers-false 62.20% <60.00%> (+0.45%) ⬆️
skip-bytebuffers-true 62.07% <60.00%> (+34.34%) ⬆️
temurin 62.21% <60.00%> (+0.45%) ⬆️
unittests 62.20% <60.00%> (+0.45%) ⬆️
unittests1 46.71% <ø> (-0.18%) ⬇️
unittests2 27.99% <60.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 07d50fb into apache:master Apr 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants