Refine PeerServerSegmentFinder #12933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
reviewed
Apr 15, 2024
| onlineServerURIs); | ||
| return !onlineServerURIs.isEmpty(); | ||
| }); | ||
| } catch (AttemptsExceededException e) { | ||
| LOGGER.error("Failed to find ONLINE servers for segment: {}, table: {}", segmentName, tableNameWithType); |
There was a problem hiding this comment.
nit: "Failed to ... in {} attempts", ..., MAX_NUM_ATTEMPTS) to make error msg a bit more clear
Jackie-Jiang
force-pushed
the
peer_server_segment_finder
branch
from
58e3057
to
246d07f
Compare
klsince
approved these changes
Apr 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12933 +/- ##
=============================================
- Coverage 61.75% 35.16% -26.59%
+ Complexity 207 6 -201
=============================================
Files 2436 2428 -8
Lines 133233 132837 -396
Branches 20636 20568 -68
=============================================
- Hits 82274 46713 -35561
- Misses 44911 82740 +37829
+ Partials 6048 3384 -2664
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
force-pushed
the
peer_server_segment_finder
branch
from
246d07f
to
dc470e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #12886 for easier review
PeerServerSegmentFinder