Refine SegmentFetcherFactory #12936
Merged
Refine SegmentFetcherFactory #12936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12936 +/- ##
============================================
+ Coverage 61.75% 62.20% +0.45%
+ Complexity 207 198 -9
============================================
Files 2436 2503 +67
Lines 133233 136463 +3230
Branches 20636 21117 +481
============================================
+ Hits 82274 84893 +2619
- Misses 44911 45296 +385
- Partials 6048 6274 +226
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
force-pushed
the
segment_fetcher_factory
branch
from
b7d20ca
to
4401fd5
Compare
klsince
approved these changes
Apr 16, 2024
| Collections.shuffle(peerServerURIs); | ||
| return peerServerURIs; | ||
| }, destTarFile, zkMetadata.getCrypterName()); | ||
| _logger.info("Downloaded tarred segment: {} from peers to: {}, file length: {}", segmentName, destTarFile, |
There was a problem hiding this comment.
nit: LOGGER or _logger?
it it possible to get which peer the data was downloaded from and log it out here?
There was a problem hiding this comment.
It should be _logger which contains the table name info.
The actual URI picked is logged on the segment fetcher side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #12886 for easier review
SegmentFetcherFactorya util classAPIwith URI supplier fromSegmentFetcherintoSegmentFetcherFactoryNote: Removed
BaseTableDataManagerTest.testDownloadFromPeersWithoutStreaming()because the test setup is incorrect (peer download scheme ishttpbut provided uri scheme isfile). Didn't add a new test because it is just testing the mocking behavior, and the real flow is tested with integration test